CliCommandLineParser icon indicating copy to clipboard operation
CliCommandLineParser copied to clipboard

Remove installation of runtime 2.1.0 from build.sh

Open dseefeld opened this issue 3 years ago • 5 comments

Installation of another runtime in build.sh doesn't work for source-build when building offline.

dseefeld avatar Jul 28 '21 19:07 dseefeld

@dseefeld Since the SDK switched over to using System.CommandLine instead of this, I was going to archive the repo. Any concerns with closing out these PRs and archiving it?

marcpopMSFT avatar Nov 29 '21 22:11 marcpopMSFT

@dseefeld Since the SDK switched over to using System.CommandLine instead of this, I was going to archive the repo. Any concerns with closing out these PRs and archiving it?

I don't think this should be closed. I would like to see this fixed, so we can remove the patch that is required to build this in source-build.

dseefeld avatar Nov 30 '21 21:11 dseefeld

@dseefeld Is templating still using commandline parser? @vlada-shubina, when will that get removed so we can archive this repo as I'm trying to save time on various compliance activities for code that's not used anymore.

marcpopMSFT avatar Dec 03 '21 22:12 marcpopMSFT

Templating is still using old parser.

https://github.com/dotnet/templating/issues/2191 is epic for migration, im working on it at the moment, but it won't be released earlier than .NET 7.

vlada-shubina avatar Dec 04 '21 00:12 vlada-shubina

templating moved to new api and source build has removed this dependency https://github.com/dotnet/installer/pull/13491

you can archive this repository and close pending prs in favor of https://github.com/dotnet/command-line-api

kasperk81 avatar Mar 30 '22 09:03 kasperk81