BenchmarkDotNet

BenchmarkDotNet copied to clipboard

feat: Add custom MsBuild targets to remove unnecessary files from bin directory

3

This PR intended to resolve https://github.com/dotnet/BenchmarkDotNet/issues/2736 ### What's changed in this PR **1. Add custom MSBuild targets file to nupkg.** This custom target is packed as `buildTransitive/BenchmarkDotNet.targets` file. And it'sused...

filzrev

[Feature Request] Reduce output binary size of project build results

1

When building BenchmarkDotNet project. `bin` directory takes about 79MB, and `runtimes` directory takes about `47MB` of them. These files are also outputted for build results of `CsProjToolChain`. Is it able...

filzrev

Add MsBuildArgument constructor supporting multiple values

2

Added MsBuildArgument(string key, params string[] values) constructor. Implemented escaping of semicolons in argument values.

jespernapp

feat: Add logics to escape MSBuildArgument text representation when contains MSBuild special chars

7

This PR intended to fix issue #2719. There is existing PR(#2729) that trying to resolve issue by escaping [MSBuild special chars](https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-special-characters?view=vs-2022) Instead, this PR try to resolve issue by surrounding...

filzrev

Auto-escape MSBuild special characters in MsBuildArgument

5

### Summary This PR adds automatic escaping of MSBuild-reserved characters in the `MsBuildArgument` class (e.g., `;`, `%`, `$`, `@`, etc.), so users no longer need to manually encode these characters...

Gal-lankri

timcassell

Feature Request: Add MsBuildArgument supports for MSBuild special characters

2

Currently [MsBuildArgument constructor](https://github.com/dotnet/BenchmarkDotNet/blob/f4bfcd67b4ed44996c67785bbc5a1340db6f88ca/src/BenchmarkDotNet/Jobs/Argument.cs#L50) accept single string argument. And this string value is passed to MSBuild command line parameter as is. So when specified string contains [MSBuild special characters](https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-special-characters?view=vs-2022) It needs...

filzrev

When attempting to run a type-based benchmark with arguments passed as parameters, if the benchmark is invalid, the system throws an unhandled exception. **Example:** ```c# public class InvalidBenchmark { }...

AvishaiDotan

Benchmark failed to build when explicitly JobId as `Default` with `.WithId("Default")`. It seems to be reserved by BenchmarkDotNet internally. **Error Logs** ``` // Build Error: Standard output: Standard error: MSBUILD...

filzrev

Compilation fails with Literal of type double cannot be implicitly converted.

4

After updating to the latest .Net 9.0 SDK and updating Visual Studio we started having issues compiling the solutions. Since we had similar issues on our codebase, maybe it is...

redknightlois