Always fail if dotnet command failed

Open timcassell opened this issue 1 year ago • 1 comments

Fixes #2533

Feb 29 '24 00:02 timcassell

@adamsitnik PTAL

Sep 04 '24 01:09 timcassell

The "the exit code might be 1 due to warnings" seems like something that might be worth keeping, maybe limit it to certain ranges of exit codes, or add some sort of command line switch like '--ignoreexitcode' so that people who were relying on the old behavior aren't stuck?

Jan 06 '25 16:01 kg

I don't know the specifics around exit code 1 for warnings, but that file is quite old, so I'm thinking that may have only been an issue with early Core sdks (which we no longer support). I wasn't able to get that result with latest sdk.

Jan 06 '25 16:01 timcassell