BenchmarkDotNet icon indicating copy to clipboard operation
BenchmarkDotNet copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Adding tests for export of csv and csv Measurements

Open Nepp3r opened this issue 2 years ago • 3 comments
trafficstars

Hello, I've noticed, that in BenchmarkDotNet.Tests.Exporters.VerifiedFiles.CommonExporterVerifyTests was todo to add CsvExporter and CsvMeasurementsExporter, so I added them and mocked verified.txt files.

Nepp3r avatar Aug 01 '23 15:08 Nepp3r

@dotnet-policy-service agree

Nepp3r avatar Aug 01 '23 15:08 Nepp3r

I have a Fedora on VM box, so clear linux, and I ran same tests with my branch, but they ended without any errors, what would cause a problem on your Linux but not on my? All verified files have CRLF end of line symbols, including files I didn't change

Nepp3r avatar Aug 02 '23 12:08 Nepp3r

was todo to add CsvExporter and CsvMeasurementsExporter

Can you remove that todo since you did it?

timcassell avatar Aug 06 '23 04:08 timcassell