BenchmarkDotNet icon indicating copy to clipboard operation
BenchmarkDotNet copied to clipboard

adjust defaultBenchmarkDotNetVersion on build

Open askazakov opened this issue 4 years ago • 2 comments

Some automatic to reconcile BenchmarkDotNet version with default version in template

If it's good enough I will fix templates for VB and F# also. If not just close PR

askazakov avatar Dec 30 '21 06:12 askazakov

CLA assistant check
All CLA requirements met.

dnfadmin avatar Dec 30 '21 06:12 dnfadmin

I need some help – locally test AwaitingTasksShouldNotInterfereAllocationResults(toolchain: Core RT 6.0.0-preview.1.21074.3) fails with System.InvalidOperationException: Sequence contains no elements, but it fails on master too.

askazakov avatar Dec 30 '21 11:12 askazakov

I've tried

var jsonNode = JsonNode.Parse(json);
jsonNode["symbols"]["version"]["defaultValue"] = $(VersionPrefix)

instead of

Regex.Replace(...)

but it leads to changes in .template.json image

should I investigate with

            var encoderSettings = new TextEncoderSettings();
            encoderSettings.AllowRange(UnicodeRanges.BasicLatin);
            encoderSettings.AllowCharacters('\u0027');

?

Or current solution with Regex is good enough?

askazakov avatar Jul 04 '23 10:07 askazakov

I've tried

var jsonNode = JsonNode.Parse(json);
jsonNode["symbols"]["version"]["defaultValue"] = $(VersionPrefix)

instead of

Regex.Replace(...)

but it leads to changes in .template.json image

should I investigate with

            var encoderSettings = new TextEncoderSettings();
            encoderSettings.AllowRange(UnicodeRanges.BasicLatin);
            encoderSettings.AllowCharacters('\u0027');

?

Or current solution with Regex is good enough?

disregard this. It will not work due to https://github.com/dotnet/msbuild/issues/5737

askazakov avatar Jul 04 '23 10:07 askazakov

@askazakov thanks!

AndreyAkinshin avatar Jul 04 '23 10:07 AndreyAkinshin