AspNetCore.Docs icon indicating copy to clipboard operation
AspNetCore.Docs copied to clipboard

Warn on MaximumReceiveMessageSize

Open guardrex opened this issue 3 years ago • 5 comments

Fixes #27013

guardrex avatar Sep 15 '22 10:09 guardrex

Let's hold off on review. We're discussing this on the PU issue. We might do something different ... an INCLUDE used in the Blazor doc and the SignalR doc, for example. We might do this, but we might only do it in the SignalR doc because the Blazor doc already links to the SignalR doc for the configuration details.

guardrex avatar Sep 16 '22 10:09 guardrex

The PU issue was closed right in the middle of the discussion on this.

Let's go with Rick's Gambit™ ... i.e. ... Call for review! 😆

Brennan, which way would you like to go?

  • Just note this on the Blazor-side, as this PR does.
  • Duplicate this for the SignalR config topic. I can place it in the Description in the table at https://learn.microsoft.com/en-us/aspnet/core/signalr/configuration?view=aspnetcore-6.0&tabs=dotnet#configure-server-options. If so, I'll add it to this PR and ping u back for final review.
  • Do something else.

guardrex avatar Sep 17 '22 23:09 guardrex

  • I can place it in the Description in the table at ...

Sure, similar to how ApplicationMaxBufferSize in a later table mentions memory usage can increase if the setting is changed.

BrennanConroy avatar Sep 19 '22 16:09 BrennanConroy

@BrennanConroy ... Added a remark to the table. How's it look?

guardrex avatar Sep 19 '22 16:09 guardrex

I will ... and btw ... I've talked myself out of using the explicit byte conventions for abbreviations, as you recommended, on the issue that I opened ...

https://github.com/dotnet/AspNetCore.Docs/issues/27056

I wish MS/.NET foundation would adopt the standard. What I can do is place a remark on it in the Blazor Fundamentals topic and just use "KB"/"MB"/"GB" everywhere.

~I'm going to perform a universal update on that per that issue, so let's not sweat it on this PR.~ UPDATE: I fixed it on this PR and will address it elsewhere on another PR.

guardrex avatar Sep 20 '22 18:09 guardrex

@BrennanConroy ... Are you OOF? No rush ... just checking.

guardrex avatar Sep 27 '22 21:09 guardrex

@BrennanConroy ... Ok ... ready for another 👁️.

guardrex avatar Sep 27 '22 22:09 guardrex