eShopOnDapr icon indicating copy to clipboard operation
eShopOnDapr copied to clipboard

Bad practices in Bicep files

Open Makciek opened this issue 2 years ago • 0 comments

Hello I checked the bicep files in this project and found that secrets are passed by the outputs(especially the cosmos key) which according to docs should not be: https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/scenarios-secrets#avoid-outputs-for-secrets

Issue example: https://github.com/dotnet-architecture/eShopOnDapr/blob/main/deploy/containerapps/modules/infra/cosmos-db.bicep#L57

Should this be fixed or at least a disclaimer be added?

Makciek avatar Feb 10 '23 09:02 Makciek