eShopOnContainers

eShopOnContainers copied to clipboard

Requesting a feature: Can we use server-side processing JQuery Datatables to list catalog?

josephwambura

Remove AddOrderItem method from Order class

3

Remove AddOrderItem from Order's public interface since it is not its behaviour.

AndriiTokarskyi

Hello, I have question about factories in domain model. Factory is responsible for new entity creating. I hope it means whole aggregate not only root entity. For example, factory takes...

Zefek

https://github.com/dotnet-architecture/eShopOnContainers/blob/9e5cd835b44aaa65c885d1a22165a3136a67b402/src/Services/Ordering/Ordering.API/Application/Commands/CreateOrderDraftCommandHandler.cs#L12 Hi guys As I see there is a MediatR decreation and injection which is not needed. Also observed cases like this in other places.

mmramezani

3 separate calls to catalog API

4

in the 'src/Web/WebSPA/Client/src/modules/catalog/catalog.component.ts', 3 separate calls are made to the catalog API to get brands, catalog, and types in the loadData() function (shown below). Why was this not done using...

andrewhaine1

Does probably throwing Exceptions here for business rules cause performance issue ?

5

Hi, I am working and reading the eShopOnContainer project and seems fantastic. You handled business rules in some domains like [here ](https://github.com/dotnet-architecture/eShopOnContainers/blob/42abcad37ebbb133aa76570c46d34c4685376913/src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs#L193) to throw an exception which is caught by...

mmramezani

In [IntegrationEvent.cs](https://github.com/dotnet-architecture/eShopOnContainers/blob/dev/src/BuildingBlocks/EventBus/EventBus/Events/IntegrationEvent.cs) [JsonConstructor] public IntegrationEvent(Guid id, DateTime createDate) { Id = id; CreationDate = createDate; } should be [JsonConstructor] public IntegrationEvent(Guid id, DateTime creationDate) { Id = id; CreationDate =...

tuskajozsef

Unit Test OrderingScenarios.Cancel_basket_and_check_order_status_cancelled causes NullReferenceException in EventBusRabbitMQ.Publish

4

When debugging the unit test OrderingScenarios.Cancel_basket_and_check_order_status_cancelled, after having almost everything done, a `NullReferenceExpcetion` is thrown by `EventBusRabbitMQ.Publish`. This does not make the test case fail in the test explorer. One...

InstanceFactory

[Question] DomainExceptions don't bubble up when called through IdentifiedHandler

3

Hi, I am working through domain validations and handling of Domain Exceptions. If i'm not mistaken Domain Exceptions do not bubble up when the Domain Exception has been created from...

benbuckland

Instrumenting telemetry data of microservices with OpenTelementry

1

**Feature Summary** Includes instrument, generate and export telemetry data(metrics, logs, and traces) for all the microservices in eShopOnContainers with [OpenTelemetry .NET](https://github.com/open-telemetry/opentelemetry-dotnet) **Required Features** - [ ] Includes `OpenTelemetry` in all...

sughosneo