HealthChecks icon indicating copy to clipboard operation
HealthChecks copied to clipboard

README.md - "This project is part of ASP.NET Core."

Open espray opened this issue 8 years ago • 9 comments

The README.md says "This project is part of ASP.NET Core." What does this mean? Has this project moved?

espray avatar Aug 29 '17 14:08 espray

It is still in Alpha here. Will be, eventually released. Hopefully in .NET Core 2.1 release, but I cannot confirm for sure.

CESARDELATORRE avatar Aug 29 '17 15:08 CESARDELATORRE

@CESARDELATORRE thanks for the reply Will this be the repro to watch, or will the work be done in different repro, or TBD?

espray avatar Aug 29 '17 18:08 espray

For now, this is it, but it might change. If that happens, we'll announce it here. :)

CESARDELATORRE avatar Aug 29 '17 19:08 CESARDELATORRE

How to use the healthcheck code then ?

ekarlso avatar Sep 29 '17 10:09 ekarlso

I forked the code and included the projs in my solution. When a Nuget package is created I will switch to that

espray avatar Sep 29 '17 14:09 espray

@ekarlso : see this post: https://scottsauber.com/2017/05/22/using-the-microsoft-aspnetcore-healthchecks-package/

rjperes avatar Oct 19 '17 09:10 rjperes

Also, see this documentation: https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/implement-resilient-applications/monitor-app-health

CESARDELATORRE avatar Oct 19 '17 20:10 CESARDELATORRE

Maybe it would make sense to change the readme anyway, because it is currently lying to the readers:

You can find samples, documentation and getting started instructions for ASP.NET Core at the Home repo.

https://github.com/aspnet/Home/search?utf8=%E2%9C%93&q=HealthChecks&type=Code

JuergenGutsch avatar Dec 06 '17 13:12 JuergenGutsch

Thanks for the feedback. I changed the text so it is not confusing. Those mentioned samples are just about ASP.NET Core, not about HealthCheck library. The examples of HealthCheck library are within this same repo or eShopOnContainers which is also using this library: https://github.com/dotnet-architecture/eShopOnContainers

CESARDELATORRE avatar Dec 06 '17 21:12 CESARDELATORRE