pdfboxing icon indicating copy to clipboard operation
pdfboxing copied to clipboard

Published 20 hours ago • verified publisher icon dotemacs

Add support for exporting pdf to image

Open werenall opened this issue 4 years ago • 7 comments

Implement a namespace for exporting a PDF or PDDocument to a BufferedImage

[Re #55] This PR also slightly changes the prerequisites for split function Previously it only allowed strings as inputs. IMHO it should also accept files.

werenall avatar Apr 02 '20 12:04 werenall

Hi @werenall

thank you for the PR.

I'd like to think about this a little bit.

But from a quick look:

you seem to have extended the functionality of an existing function and added a new feature in the same commit message. I think that this should be split in separate commits.

This is just from a quick glance.

dotemacs avatar Apr 02 '20 12:04 dotemacs

Yeah, I agree. Take all the time you need and just let me know in a bulk what I can improve.

werenall avatar Apr 02 '20 12:04 werenall

To summarise:

The changes in pdfboxing.split are they in any way related to this pull request? I don't see how they are.

The same with pdfboxing.merge, is it related to this pull request, feature wise?

I'd say that only the addition of pdfboxing.image is relevant for this pull request.

Since you mentioned in https://github.com/dotemacs/pdfboxing/issues/55 why you've created it, I have some context, but maybe you can add an example on how it can be used in the README?

For me to add this PR, it would be nice to see the following:

  • removal of the changes from this PR from pdfboxing.split & pdfboxing.mege
  • a clear example of the usage of the function pdfboxing.image/export-to-image
  • also, why does it only take the first page? I get that it satisfies your use case when creating thumbnails, but let's say that somebody wanted to use nth page from the PDF document, is this 0 on this line https://github.com/dotemacs/pdfboxing/pull/56/files#diff-f29a5a4bdf7329ef9a0076770cb59571R27 used to specify that first page? if it is, maybe it can be set as an option using :or in the destructuring argument?

Thank you for your work

dotemacs avatar Sep 05 '20 08:09 dotemacs

Ok @dotemacs, I think I resolved all your comments. Let me know if you still would like some fine-tuning.

werenall avatar Nov 12 '20 17:11 werenall

how is this PR going? i'm looking into this feature too

glfeng318 avatar Aug 02 '21 09:08 glfeng318

HI @dotemacs, I wonder if you plan to merge this PR? thank you for your work on this lib.

jgrodziski avatar Dec 27 '23 11:12 jgrodziski

Gentle ping ☺️ Also re: this comment: https://github.com/dotemacs/pdfboxing/issues/55

avocade avatar Mar 11 '24 16:03 avocade