graphql-code-generator icon indicating copy to clipboard operation
graphql-code-generator copied to clipboard

fix: allow deferredFields works with fragment

Open ludusrusso opened this issue 1 year ago • 4 comments

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

With this PR, __meta__.deferredFields are generated also in case of fragment with deferred nested fragment, this will fix an issue with isFragmentReady that returns always true in that case

Related #9564

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] I've updated client preset tests
  • [ ] Test locally with example repo

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

ludusrusso avatar Jul 25 '23 11:07 ludusrusso

⚠️ No Changeset found

Latest commit: bd3af2ff35ecde4ad9673cfa28e04278c0f6371e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 25 '23 11:07 changeset-bot[bot]

Any news about this PR?

ludusrusso avatar Sep 11 '23 07:09 ludusrusso

Hi! any news regarding this PR?

2snEM6 avatar Dec 24 '23 11:12 2snEM6

Still waiting for approval! @beerose there is something I can do?

ludusrusso avatar Jan 27 '24 21:01 ludusrusso