graphql-code-generator
graphql-code-generator copied to clipboard
dotansimha
Add an implementation for C# composition types
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Adding an implementation of Composition Types (Union Types and Interfaces) for the c# plugin, as discussed in the related issue. Related # (issue) #6858
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
Added tests related to composition types in test snapshots
Test Environment:
- OS: Win10
-
@graphql-codegen/...: fresh master - NodeJS: 14.15
Checklist:
- [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
⚠️ No Changeset found
Latest commit: 629cb3e85972a1cf7930465f8991197d88d77661
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/theguild/graphql-code-generator/Ebn6GNDUb8iS93WExoCxxFrgRGD5
✅ Preview: https://graphql-code-generator-git-fork-cicciodm-c-union-types-theguild.vercel.app
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey, there! Can you please rebase this? What is missing before we can merge this?
@HerrNiklasRaab I have been completely swamped with work over the last month, I will try to address comments and provide a new iteration during the weekend.
This would be really nice to have. Currently C# plugin generates invalid code that cannot be compiled.
I will have time to continue the work on this PR this week! Thanks for your patience :D
Thank you @seclerp! I can see that Vercel had a failure during deployment, do you know who could assist in completing the PR?
Just pushed some fixes after merging with master, this looks ready to check in now :)
@cicciodm anywhere I can send you a coffee, so you might be able to finish this? :)
Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.
Community plugins:
-
@graphql-codegen/typescript-react-apollo -
@graphql-codegen/typescript-graphql-request -
@graphql-codegen/typescript-apollo-angular -
@graphql-codegen/typescript-apollo-client-helpers -
@graphql-codegen/typescript-react-query -
@graphql-codegen/typescript-urql -
@graphql-codegen/named-operations-object -
@graphql-codegen/urql-introspection -
@graphql-codegen/flow-resolvers -
@graphql-codegen/typescript-vue-apollo -
@graphql-codegen/typescript-rtk-query -
@graphql-codegen/flow-operations -
@graphql-codegen/typescript-msw -
@graphql-codegen/typescript-mongodb -
@graphql-codegen/typescript-type-graphql -
@graphql-codegen/jsdoc -
@graphql-codegen/typescript-vue-urql -
@graphql-codegen/kotlin -
@graphql-codegen/typescript-vue-apollo-smart-ops -
@graphql-codegen/java -
@graphql-codegen/c-sharp-operations -
@graphql-codegen/hasura-allow-list -
@graphql-codegen/typescript-stencil-apollo -
@graphql-codegen/relay-operation-optimizer -
@graphql-codegen/typescript-oclif -
@graphql-codegen/java-resolvers -
@graphql-codegen/java-apollo-android -
@graphql-codegen/flutter-freezed
Please move your PR by following these steps:
From your current PR branch:
- git remote add codegen-community [email protected]:dotansimha/graphql-code-generator-community.git
- git fetch codegen-community
- git push codegen-community
Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!
