graphql-code-generator icon indicating copy to clipboard operation
graphql-code-generator copied to clipboard

test(client-preset): custom suffix with `namingConvention`

Open hecticme opened this issue 1 year ago • 1 comments

Description

When handling anonymous operation name, BaseDocumentsVisitor calls the convertName() method twice. This leads to duplicated suffix if a user provide a custom namingConvention function.

Related #10012

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

https://stackblitz.com/edit/gql-codgen-13f1zd

image

How Has This Been Tested?

I have described the problem in the related issue. The test added in this PR will reflect that.

Test Environment:

  • OS: Linux 6.8 Fedora Linux 40 (Workstation Edition)
  • NodeJS: 20.14.0
  • graphql version: 16.8.2
  • @graphql-codegen/cli version: 5.0.2

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

The main problem that I want to address is that the operation name does not match with itself inside Typed Document Node.

hecticme avatar Jun 19 '24 10:06 hecticme

⚠️ No Changeset found

Latest commit: 96c266714abe4680f5b6d67da7d60fb494666830

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 19 '24 10:06 changeset-bot[bot]