Dotan Simha

Results 242 comments of Dotan Simha

We implemented a visitor (with type info) for both schema and queries in https://github.com/dotansimha/graphql-tools-rs , also a (almost) spec-compliant validation phase. Thanks for this PR, it was a great inspiration!

> @dotansimha why did you post this in 3 different places? 😅 I saw these PRs are duplicated anyway, so I hope it would help someone :) I'll delete if...

> @tailhook > > > This may be useful for very simple things, like statistics or finding all type names used. > > I wonder if we can support validation...

> This sounds like specifying key twice is useless, just we don't check for that speficically, right? Yeah, but according to the spec, this is not a concern for the...

> I'm not sure yet. I wonder what others think on this. /cc @graphql-rust/graphql-parser-maintainers, @graphql-rust/graphql-client-maintainers Hi @tailhook , any update on that? thanks!

> Is this something where the server wants the `Vec` to be able to tell the difference, but a client wants `BTreeMap` to avoid having invalid states it sends? I...

@tailhook any chance we can get this merged?

> In general, the idea was that people have to deep import it and that it should not be re-exported from the root (even in Node.js). Maybe we can address...

@ardatan @n1ru4l any insights from the recent work in codegen that might be related to it? :D