Chen

Results 30 comments of Chen

``` Direct initialization still selects the converting constructor (this probably cannot be changed). ``` As i said in #2213, this is why an exception is raised when calling `std::optional(j_null)`. It...

What is more, `std::optional(j_null)` still raises an exception. I added logs to check `SECTION("string")` and `bool`, `number`. Unfortunally, I found that they still didn't call the expected method - `from_json(basic_json,...

I am working for checking these CI tasks. Restart the travis CI tasks, and then they would be fine. [This Appveyor CI task](https://ci.appveyor.com/project/nlohmann/json/builds/33010708/job/jnlg1wm6cnpewdfn) may be ok after we restart, it...

**More Info :** The `std::optional` code maybe not included. I had added logs in `unit-conversions.cpp` to check if the testcases of `std::optional` had been run: ``` .... SECTION("traditional enum") {...

> Yes, the tests are only executed in C++17 mode. Strangely, not all of them fail, but only a few of them. I find that the `` tests are only...

glad to see some progress in this.

Do we have plans to upgrade log4j2 to 2.117.1? CVE-2021-45105 affected.

> @dota17 The title says "WIP". Are you still working on it? Yes, I am. If anyone has time to review, it would be really nice. ;-) Thanks

Hi @garydgregory Under the folder commons-collections/src/test/java/org/apache/commons/collections4 (junit5WithExceptions), I executed the command to get the fails without annotate and import. `grep -R fail * | grep -v import |grep -v "\/\/"...

Hi @garydgregory I want to migrate to JUnit5 Jupiter. Such as the pr : https://github.com/apache/commons-csv/pull/49 Is it OK ?