Morten Nielsen
Morten Nielsen
Nice find
> This library sends out 1,0,0,0 and the linked js library sends out some values. This is the Identifier field's value in the library. That number should increase on each...
> I changed the initial value from 1 to 2, and I see all devices. That's rather surprising. That number should keep increasing though.
> I think you are confusing this with the 'sequence' field from Frame Address It's been a while since I looked at all this code (and I'm already cringing at...
See here where it increases: https://github.com/dotMorten/LifxNet/blob/772d14eb79643869dfcc4164c0ba07370ca0dfa5/src/LifxNet/LifxClient.Discovery.cs#L19-L23
I think there's some major rewriting that needs to happen. That line you quoted should probably be a constant instead. And each device needs a Sequence value it increments for...
Great find! I do think the fix is a bit significant though. I have stopped using my LIFX bulbs though (I've moved to Zigbee lights which I find work better...
If you make a PR, I'd be happy to accept it, but please try and keep changes to a minimum, so code reviews will be faster. Avoid major refactoring (would...
Can you provide an example for that? Personally never seen this