core icon indicating copy to clipboard operation
core copied to clipboard

fix(CLI): Limited user can not operate without errors

Open fabrizzio-dotCMS opened this issue 1 year ago • 1 comments

Proposed Changes

  • FileFetcher is class used by PullService to traverse folders remotely. The flag fail was hard coded to true therefore when a limited user would run into a permission denied response the exceptions would no longer let the pull process complete.
  • WeAssetHelper class had issues. It needs to be transactional since it does two operations. It creates the file and then it publishes it (if needed).
  • Now we're validating the publish permissions before attempting the operation.
  • Another problem that needs attention is that RemoteFolderTraversalTask when instructed to continue instead of fast-failing, can return A Null TreeNode accompanied with a List of Exceptions. But this can lead to an NPE. We need to make small refactoring to make the code more semantic and force revising the state of the returned TreeNode

fabrizzio-dotCMS avatar Feb 22 '24 20:02 fabrizzio-dotCMS