core icon indicating copy to clipboard operation
core copied to clipboard

[UI] Setup scheduling for experiment

Open oidacra opened this issue 2 years ago • 1 comments

As a user, I need set up the start and end dates to schedule and run an experiment.

Create Experiments - Traffic split

Requirements:

  • When the user clicks Setup open a sidebar with the form Scheduliing

  • Save the changes (DONE)

  • Update the view (when you set up the schedule, the status change to SCHEDULED, you need update the status bar of the experiment) Create Experiments - Scheduling

  • The Sidebar can be called by the icon clock in the status of the experiment Screen Shot 2022-09-14 at 2 34 46 PM

oidacra avatar Sep 14 '22 16:09 oidacra

Hey team! Please add your planning poker estimate with Zenhub @alfredo-dotcms @fmontes @hmoreras @rjvelazco

oidacra avatar Sep 14 '22 18:09 oidacra

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 01 '22 03:12 stale[bot]

@freddyucv @dsilvam please add endpoint

oidacra avatar Dec 20 '22 16:12 oidacra

Needs Works: Now we are setting day, hour and minutes to the START/STOP scheduling, but the Job on the backend is going to run each 30 minutes so we need to set it every 30 minutes

freddyucv avatar Feb 06 '23 17:02 freddyucv

PR: https://github.com/dotCMS/core/pull/24050

hmoreras avatar Feb 10 '23 17:02 hmoreras

Needs work:

Step to reproduce:

  • Create a Experiment.
  • Add a Start end end date.
  • Now edit the Experiment Scheduling and remove the start and end date.
  • Yo got a error.

freddyucv avatar Feb 17 '23 16:02 freddyucv

Needs work: We should not allow to set end date if we don't have a start date

freddyucv avatar Feb 17 '23 16:02 freddyucv

PR: https://github.com/dotCMS/core/pull/24213

dsilvam avatar Feb 27 '23 17:02 dsilvam

Passed Internal QA: Able to remove start and end dates from scheduling after initially set.

dsilvam avatar Feb 28 '23 16:02 dsilvam

Tested on release-23.05 and we need some work here:

  • We are not validating you set both values start and end dates, you can start an experiment without any of those, then the experiment never will start or never will end.
  • We need to make the validation at FE and endpoint level too
  • We need postman test for the endpoint
  • In case the start date is after the end date, we are showing an error at UI level but we need to catch this exception and print just a line error in the log, this because right now we are printing to many lines of noisy in the log. Here the stack trace: https://gist.github.com/bryanboza/613e1ba6eaf4d08f263cd60381025853

bryanboza avatar Apr 14 '23 16:04 bryanboza

PR: https://github.com/dotCMS/core/pull/24649

dsilvam avatar Apr 17 '23 14:04 dsilvam

Need works

  • We still have this
In case the start date is after the end date, we are showing an error at UI level but we need to catch this exception and print just a line error in the log, this because right now we are printing to many lines of noisy in the log.
Here the stack trace: https://gist.github.com/bryanboza/613e1ba6eaf4d08f263cd60381025853

Also if we try to set in the UI the end Date before that Start Date, it validate and make the End Date equals to the Start Date

Screenshot 2023-04-20 at 11 08 20

And it need to be The time needs to be in 30-minute steps

freddyucv avatar Apr 20 '23 15:04 freddyucv

new Rules added.

  1. End date can't be set in the past never.
  2. When the start date is set, the end date minimum start time, should be +30 min.
  3. If the start date value is lower that the end date, the end date should be cleared

PR: https://github.com/dotCMS/core/pull/24711

hmoreras avatar Apr 21 '23 15:04 hmoreras

Needs work: If you set a future date with same hours at the start date then you can edit the future date and make it the same as the start date, which fails upon trying to save.

Image

dsilvam avatar Apr 25 '23 16:04 dsilvam

Passed Internal QA: This is respecting now the minimun length for the Experiment, which is 90 days by default.

dsilvam avatar Jun 01 '23 23:06 dsilvam

Fixed, now we are disabling all the invalid options once that you set the start date. Also tested at API level and we are returning the correct error codes and messages.

bryanboza avatar Jun 27 '23 21:06 bryanboza