core
core copied to clipboard
[UI] Setup scheduling for experiment
As a user, I need set up the start and end dates to schedule and run an experiment.
Requirements:
-
When the user clicks
Setup
open a sidebar with the form -
Save the changes (DONE)
-
Update the view (when you set up the schedule, the status change to SCHEDULED, you need update the status bar of the experiment)
-
The Sidebar can be called by the icon clock in the status of the experiment
Hey team! Please add your planning poker estimate with Zenhub @alfredo-dotcms @fmontes @hmoreras @rjvelazco
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@freddyucv @dsilvam please add endpoint
Needs Works: Now we are setting day, hour and minutes to the START/STOP scheduling, but the Job on the backend is going to run each 30 minutes so we need to set it every 30 minutes
PR: https://github.com/dotCMS/core/pull/24050
Needs work:
Step to reproduce:
- Create a Experiment.
- Add a Start end end date.
- Now edit the Experiment Scheduling and remove the start and end date.
- Yo got a error.
Needs work: We should not allow to set end date if we don't have a start date
PR: https://github.com/dotCMS/core/pull/24213
Passed Internal QA: Able to remove start and end dates from scheduling after initially set.
Tested on release-23.05 and we need some work here:
- We are not validating you set both values start and end dates, you can start an experiment without any of those, then the experiment never will start or never will end.
- We need to make the validation at FE and endpoint level too
- We need postman test for the endpoint
- In case the start date is after the end date, we are showing an error at UI level but we need to catch this exception and print just a line error in the log, this because right now we are printing to many lines of noisy in the log. Here the stack trace: https://gist.github.com/bryanboza/613e1ba6eaf4d08f263cd60381025853
PR: https://github.com/dotCMS/core/pull/24649
Need works
- We still have this
In case the start date is after the end date, we are showing an error at UI level but we need to catch this exception and print just a line error in the log, this because right now we are printing to many lines of noisy in the log.
Here the stack trace: https://gist.github.com/bryanboza/613e1ba6eaf4d08f263cd60381025853
Also if we try to set in the UI the end Date before that Start Date, it validate and make the End Date equals to the Start Date

And it need to be
The time needs to be in 30-minute steps
new Rules added.
- End date can't be set in the past never.
- When the start date is set, the end date minimum start time, should be +30 min.
- If the start date value is lower that the end date, the end date should be cleared
PR: https://github.com/dotCMS/core/pull/24711
Needs work: If you set a future date with same hours at the start date then you can edit the future date and make it the same as the start date, which fails upon trying to save.
Passed Internal QA: This is respecting now the minimun length for the Experiment, which is 90 days by default.
Fixed, now we are disabling all the invalid options once that you set the start date. Also tested at API level and we are returning the correct error codes and messages.