Site Selector not showing pagination

[erickgonzalez]

Describe the bug We updated the site selector in 22.02, but we missed/broke a few things.

1. We should show more hosts by default. I would say we should a least 20 per page if not more.
2. When a user clicks on the host selector, their cursor should focus in on the input box so they can immediately start typing.
3. We should show the pagination controls if they are needed

To Reproduce Steps to reproduce the behavior:

1. Create over 10 sites.
2. Open the pagination.

Expected behavior According to @fmontes Pagination controls should be in one line.

Screenshots

Reproducible in 21.06 LTS.

Note: demo (22.08) the site selector doesn't even paginate so I couldn't test over there.

[erickgonzalez]

Customer ticket: https://dotcms.zendesk.com/agent/tickets/108172

[nollymar]

PR: ~#22765~

[nollymar]

Note to QA: ~According to #21417, we should show at least 40 sites before we paginate~ After a discussion, we agreed:

• Pagination won't be enabled on the site selector.
• The max number of records to be listed will be 15.
• The filter will keep working as it is and can be used by the user to get more narrowed results.

[alfredo-dotcms]

PR: https://github.com/dotCMS/core/pull/22773/files

[nollymar]

Internal QA: Passed

Now, the pagination is not displayed and the max records listed is 15:

This change also works when applying a filter:

[josemejias07]

Failed QA - Tested on 22.09_cb5a8a1d_SNAPSHOT // Docker // FF

Max number of sites showing on the search drop down should be set to 15. Right now only shows 10 entries tops.

Comment from Nollymar on https://github.com/dotCMS/core/issues/22734#issuecomment-1216079537

The max number of records to be listed will be 15.

[nollymar]

@josemejias07 please test again with a new docker image because that image was corrupted. I tried with this one 22.09_82a5e0cb_SNAPSHOT and it's working

[wezell]

@nollymar @josemejias07 - also, please confirm that

1. the cursor is focus in the search box when you click the control
2. Bonus test - Keyboard navigation up and down works

[josemejias07]

Failed QA - Tested on 22.09_82a5e0cb_SNAPSHOT // Docker // FF

Selection of objects of the drop down fields should be perform with the use of up and down keys. Currently focus only remains on the search field.

Comment from Will https://github.com/dotCMS/core/issues/22734#issuecomment-1221329879

The max number of records is working fine.

[nollymar]

@josemejias07, the use of the keys has never been enabled for this dropdown and is not part of the scope of this issue. Could you please file a new card, so we can discuss the priority of this new requirement with @wezell ?

[nollymar]

Sorry @josemejias07 I hadn't seen this comment https://github.com/dotCMS/core/issues/22734#issuecomment-1221329879

@josemejias07, the use of the keys has never been enabled for this dropdown and is not part of the scope of this issue. Could you please file a new card, so we can discuss the priority of this new requirement with @wezell ?

[nollymar]

@josemejias07 as discussed on the meeting, the new requirement for the keys will be implemented on https://github.com/dotCMS/core/issues/22835. So, I think we can pass this one, right?

[josemejias07]

Pass QA - Tested on 22.09_2c7af5a0_SNAPSHOT // Docker // FF

Additional pending behavior will be work on https://github.com/dotCMS/core/issues/22835

Thanks @nollymar