core icon indicating copy to clipboard operation
core copied to clipboard

What's Changed UI issues

Open erickgonzalez opened this issue 2 years ago • 3 comments

Describe the bug The What's Changed presents 2 UI issues: 1- The checkbox isn't checking (but it works). 2- When enabling the What's Changed Feature, there is no way to disable it.

To Reproduce Steps to reproduce the behavior:

  1. Site > Browser
  2. Select any page
  3. Go to Preview Mode
  4. Click over the What's Changed Checkbox
  5. Checkbox doesn't check but enables the feature**(First issue)**
  6. Click over again the Checkbox to disable the feature
  7. Nothing happens (Second Issue)

Expected behavior We should check the checkbox whenever the feature is enabled, and we should be able to disable the feature.

Screenshots https://user-images.githubusercontent.com/5278970/182632491-99b3c08a-b114-4261-9db8-d50793cac2ee.mov

Reproducible in 22.03.2 LTS, demo (22.06).

Customer ticket: https://dotcms.zendesk.com/agent/tickets/108067

erickgonzalez avatar Aug 03 '22 14:08 erickgonzalez

dupe of #22280

nollymar avatar Aug 12 '22 15:08 nollymar

PR https://github.com/dotCMS/core/pull/22752

alfredo-dotcms avatar Aug 12 '22 16:08 alfredo-dotcms

Internal QA: Passed

https://user-images.githubusercontent.com/8741395/188005512-aaf174fc-a1fb-4a94-a874-b3892fe2158b.mov

nollymar avatar Sep 01 '22 20:09 nollymar

Approved QA - Tested on 22.09_a506dc69_SNAPSHOT // Docker // mac OS 12.6 FF 105.

Note: I did made some changes to the UI using the layout tool of the browser and no changes were recorded. I know that this is a part of the Time Machine functionality therefore I'm not sure if the changes I made will count as a proper workflow.

josemejias07 avatar Sep 23 '22 14:09 josemejias07

Not reproducible in 21.06 LTS

erickgonzalez avatar Oct 26 '22 22:10 erickgonzalez