core icon indicating copy to clipboard operation
core copied to clipboard

Relationships are not respecting changes to requiredness

Open swicken-dotcms opened this issue 2 years ago • 3 comments

Describe the bug When you change the existing required state of a relationship, the requiredness does not change functionally. It correctly displays the checkbox based on your selection, but when actually managing relationships it does not respect the state of the checkbox.

Reproduced on: 22.03/22.06

To Reproduce

  1. Create a relationship between two content types, set it to required
  2. Attempt to create a contentlet without specifying a related content
  3. Save, you will correctly get an error stating the relationship is required
  4. Change the relationship to Not Required (unchecked)
  5. Reopen the relationship, the required checkbox will remain unchecked
  6. Attempt to create a contentlet without specifying a related content
  7. Save, you will no incorrectly still receive the error stating a relationship is required

Acceptance Criteria You should be able to change the requiredness of a relationship

swicken-dotcms avatar Jul 07 '22 13:07 swicken-dotcms

Another customer hitting this: https://dotcms.zendesk.com/agent/tickets/108057

erickgonzalez avatar Jul 29 '22 16:07 erickgonzalez

looking at this seems like the verification of requiredness happens in the BE and for some reason the changes in the CT model is not updated

image

alfredo-dotcms avatar Aug 12 '22 22:08 alfredo-dotcms

Hey team! Please add your planning poker estimate with Zenhub @hmoreras @jcastro-dotcms @jdotcms @rjvelazco

fmontes avatar Sep 09 '22 16:09 fmontes

IQA Status: Unable to Reproduce

I confirmed with @bryanboza that this issue is not reproducible with the provided steps to reproduce in the latest stable dotCMS 22.10 Docker image. Creating a required Relationships field in a Content Type and then removing such a status is not causing the required message to keep showing up.

jcastro-dotcms avatar Oct 07 '22 21:10 jcastro-dotcms

Looks like this is for a specific version, we might need to patch it up.

fmontes avatar Oct 10 '22 13:10 fmontes

Tested on release- 22.10 and I'm unable to reproduce

bryanboza avatar Oct 10 '22 15:10 bryanboza

Still happens on 22.03.4 LTS need to debug to check what is going on

erickgonzalez avatar Dec 06 '22 18:12 erickgonzalez

Not reproducible in 23.01 LTS

erickgonzalez avatar Apr 03 '23 15:04 erickgonzalez

PR for 22.03 LTS: https://github.com/dotCMS/core-web/pull/2015

dsolistorres avatar Apr 04 '23 22:04 dsolistorres