DownloadNet icon indicating copy to clipboard operation
DownloadNet copied to clipboard

Add command line flag to set browser binary

Open crisdosaygo opened this issue 4 years ago • 6 comments

This could help people use Brave, and work on issues that seem to involve not finding the browser.

crisdosaygo avatar Mar 17 '22 01:03 crisdosaygo

Vivaldi user here. I have managed to let diskernet launch Vivaldi by adding export CHROME_PATH="/Applications/Vivaldi.app/Contents/MacOS/Vivaldi" to .profile. The only issue is diskernet still observes the default Chrome settings directory.

Terminal:

Args usage: <server_port> <save|serve> <chrome_port> <library_path>
Running in node...
Importing dependencies...
Attempting to shut running chrome...
There was no running chrome.
Removing 22120's existing temporary browser cache if it exists...
Launching library server...
Library server started.
Waiting 1 second...
{"server_up":{"upAt":"2022-03-23T09:06:40.140Z","port":22120}}
Launching chrome...
Chrome started.
Waiting 1 second...
Launching archivist and connecting to browser...
Observing /Users/XXXX/Library/Application Support/Google/Chrome/Default
System ready.

levitabris avatar Mar 23 '22 09:03 levitabris

@crisdosyago @levitabris What steps do you think might be necessary for an SSB such as Epichrome? Epichrome uses Brave, but it places each browser profile into a unique directory under ~/Library/Application Support/Epichrome/Apps. It runs a script that launches Brave with the appropriate launch flags, similar to this project.

Do you think it's possible to merge the functionality of this project with an Epichrome browser, and if so, what do you think would be the best way to do it? What snags should I be aware of that might conflict between the two?

ylluminarious avatar Mar 31 '22 04:03 ylluminarious

I'd love a flag to get Diskernet working with Edge

worldofgeese avatar Sep 24 '22 16:09 worldofgeese

Oh thank you for that @levitabris, @ylluminarious and @worldofgeese! :)

crisdosaygo avatar Sep 24 '22 17:09 crisdosaygo

Vivaldi appears to work

$ CHROME_PATH="/usr/bin/vivaldi-stable" diskernet 
/usr/lib/node_modules/diskernet/build /usr/lib/node_modules/diskernet/build/diskernet.cjs
{ APP_ROOT: '/usr/lib/node_modules/diskernet/build' }
{ root: '/usr/lib/node_modules/diskernet/build' }
Args usage: <server_port> <save|serve> <chrome_port> <library_path>
Running in node...
Importing dependencies...
Removing 22120's existing temporary browser cache if it exists...
Launching library server...
No certs found so will use insecure no SSL.
Library server started.
Waiting 1 second...
{"server_up":{"upAt":"2023-01-23T03:14:11.190Z","port":22120}}
Launching chrome...
  LH:ChromeLauncher No debugging port found on port 9222, launching a new Chrome. +0ms
  LH:ChromeLauncher:verbose created /tmp/lighthouse.37aPsxZ +101ms
  LH:ChromeLauncher:verbose Launching with command:
  LH:ChromeLauncher:verbose "/usr/bin/vivaldi-stable" --remote-debugging-port=9222 --disk-cache-dir=/home/user/.config/dosyago/DiskerNet/22120-arc/temp-browser-cache0.6957129115711098 --aggressive-cache-discard http://localhost:22120 +1ms
  LH:ChromeLauncher:verbose Chrome running with pid 26659 on port 9222. +15ms
  LH:ChromeLauncher Waiting for browser. +0ms
  LH:ChromeLauncher Waiting for browser... +0ms
  LH:ChromeLauncher Waiting for browser..... +502ms
  LH:ChromeLauncher Waiting for browser....... +502ms
  LH:ChromeLauncher Waiting for browser.......✓ +2ms
Chrome started.
Waiting 1 second...
Launching archivist and connecting to browser...
{ Mode: 'save' }
Not observing
System ready.

but http://localhost:22120 displays nothing ...

nobicycle avatar Jan 23 '23 03:01 nobicycle