Aaron Niskode-Dossett

Hi @yufangong I would be happy to, once i figure out how to use the new type. Do you know of any examples of the verbose option being set with...

Thank you! If I'm understanding that PR correctly, adding a verbose option would require creating a new `ServiceOption` like `case object WithVerbose extends ServiceOption` and then adding logic to `Generator.scala`...

Just to clarify @yufangong what I mean is that it used to be possible to pass the verbose flag to scrooge with: `scroogeBuildOptions in Compile := Seq("--verbose")` But now it...

Seems good to me (non-binding!). Revisiting whether or not the caching strategy make sense might be worthwhile, but that shouldn't stop this fix. Small comment: I would remove most of...

Seems good to me (non-binding!). Revisiting whether or not the caching strategy make sense might be worthwhile, but that shouldn't stop this fix. Small comment: I would remove most of...

@shangxinli I do not feel strongly about it. I think historical context is better kept in JIRAs and PR discussion than in code comments, but that is just a style...

I am not an expert here by any means, but I have made (very small) changes related to default values in protobuf parquet before and the goal of this change...

I am not an expert here by any means, but I have made (very small) changes related to default values in protobuf parquet before and the goal of this change...

@belugabehr This looks really good! I'm probably going to be working a lot with protobuf + parquet in the future, so I'm happy to see changes like this. I'm not...

That's a good one too @belugabehr ! I posed this question on the parquet dev list about proto3 if you are interested: http://mail-archives.apache.org/mod_mbox/parquet-dev/202009.mbox/%3CCAMgkoMJmLX%2BNc0-qnMLqkx6aGL1wW%3DMeJkGGTONG3ypmj9LUyw%40mail.gmail.com%3E