angular-localization icon indicating copy to clipboard operation
angular-localization copied to clipboard

Start index of parameterized substitution of strings

Open renatoch opened this issue 9 years ago • 5 comments

I'm using the parameterized substitution of strings, using {1}, {2}.

The project uses same resource files for angular and ASP.NET C#, and it starts the index on {0}. This will cause confusion and inconsistencies between resources used on both sides.

Is there a way to make angular-localization use 0 based substitutions?

renatoch avatar May 22 '15 17:05 renatoch

@renatoch will it work if I provide a configParam you can override (default to 0 if you do nothing in order to preserve existing functionality)

doshprompt avatar May 23 '15 04:05 doshprompt

Yeah, it sure would, that would be perfect! Em 23/05/2015 01:54, "Rahul Doshi" [email protected] escreveu:

@renatoch https://github.com/renatoch will it work if I provide a configParam you can override (default to 0 if you do nothing in order to preserve existing functionality)

— Reply to this email directly or view it on GitHub https://github.com/doshprompt/angular-localization/issues/48#issuecomment-104843846 .

renatoch avatar May 23 '15 15:05 renatoch

@doshprompt We need this urgently in our project, so we are willing to fix it and send a pull request, unless you are already looking into it. Anyway, I will implement a workaround for today and wait for your reply.

Thanks

thiagoalves avatar Jul 01 '15 20:07 thiagoalves

@thiagoalves I am happy to take a look at your PR once you have it. I was thinking about the issue but have not implemented it yet, sorry :(

doshprompt avatar Jul 01 '15 20:07 doshprompt

@doshprompt No problem. I will come back with it in a few days.

thiagoalves avatar Jul 01 '15 22:07 thiagoalves