fdpp icon indicating copy to clipboard operation
fdpp copied to clipboard

A0 01

Open andrewbird opened this issue 1 year ago • 6 comments

For discussion

andrewbird avatar Mar 09 '24 18:03 andrewbird

What are your thoughts about the $_lfn_support = (on) setting in dosemu.conf? I can see it made sense when lfn support was processed before any TSR, but now dosemu's lfn is only a fallback is it still relevant?

andrewbird avatar Mar 09 '24 18:03 andrewbird

What do you propose?

stsp avatar Mar 09 '24 18:03 stsp

I was thinking of removal of that config option, but I suppose it may be too early. I'll just need to disable the test for it under FDPP.

andrewbird avatar Mar 09 '24 19:03 andrewbird

Yes, I think its mainly historic. There were times when some DOSes were unbootable once you enable lfn support (eg 198bc9c), and even in dosemu2 history we have the wtf things like f1002e0 13f4867 bf281b9

But I guess disabling LFNs should never be a cure, esp since we do support LFNs in comcom64. It can also be moved to emuconf.com to allow disabling dynamically (in case some program fails with LFNs). So the question is how "deeply" to remove it. Removing from dosemu.conf sounds good, maybe also from parsers, but leave in the code and eventually add to emuconf.com? @bartoldeman do you have an opinion on that?

stsp avatar Mar 09 '24 19:03 stsp

Ah, commit hashes didn't work, as we are in fdpp, not dosemu2...

stsp avatar Mar 09 '24 19:03 stsp

That would be https://github.com/dosemu2/dosemu2/commit/198bc9c https://github.com/dosemu2/dosemu2/commit/f1002e0 https://github.com/dosemu2/dosemu2/commit/13f4867 https://github.com/dosemu2/dosemu2/commit/bf281b9

andrewbird avatar Mar 10 '24 12:03 andrewbird