doroved
Add flag to not create a powershell window on Windows
When I use your package in Tauri.app. It automatically opens a powershell window to run the command.
So I added an option to prevent it from opening additional windows on Windows.
Can you help me check if this is possible?
Thank you!
Hi, I don't have Windows, but I'll try running this code through Github Actions and see if it breaks the tests.
Hello, I just tested your crate to build a license system. But having a terminal window showing up a fraction of second will not reassure our users. Can we merge this pull request please ?
Thank you very much for your implementation of machine id crate !
Hello, I just tested your crate to build a license system. But having a terminal window showing up a fraction of second will not reassure our users. Can we merge this pull request please ?
Thank you very much for your implementation of machine id crate !
Hi, have you checked to see if this PR is working? I just don't have a chance to test it as I use mac.
Hey ! Yep I tested it on Windows 11 and no powershell/terminal window poping-up. 👍
I'm using this branch right now in prod.
FWIW we have a different use-case - we use this crate in a terminal app and not a Tauri app. It turns out that the -WindowStyle hidden flag used in the Powershell invocation hides the current terminal window that our app is running in when we first query the machine ID. However, I tested the patch in this PR and it looks like it also prevents the issue we are having with the terminal window unexpectedly being hidden.
So, +1 for merging this PR.
