Dominic Orchard

icon indicating a website link http://dorchard.github.io

icon location Canterbury, UK icon location Co-director of Institute of Computing for Climate Science, University of Cambridge and Senior Lecturer at the School of Computing, University of Kent

Results 99 comments of Dominic Orchard

Query about `-a` flag

The latter would be very easy to implement and backwards compatible so that might be the best choice.

Add parsec dependency to install instructions.

Thanks Sarah! We have a new and exciting version of this library brewing- our Research Assistant has been working very hard on it and it will hopefully appear in the...

Incorrect handling of continuation lines in fixed-form FORTRAN

Thanks for this. We need to add this. Hopefully we can do this soon.

Introduce integration tests based on the examples

Can you add some documentation about how to run locally?

Unit tests (using pFunit)

tests/test_ftorch.pf gives a start of a unit test for `torch_tensor_from_blob`

Unit tests (using pFunit)

There's a start here, but it got a bit stalled as I could use some help with the cmake. Perhaps someone is able to work with me on this? @TomMelt...

Unit tests (using pFunit)

I'm having issues building the unit tests, e.g.: ``` [ 37%] Building Fortran object test/unit/CMakeFiles/test_constructors.dir/test_constructors.F90.o /Users/dorchard/Documents/iccs/FTorch/src/build/test/unit/test_constructors.F90:10:7: 10 | use pFUnit | 1 ``` I am using pfunit-4.10 whose mod files...

Unit tests (using pFunit)

Looks good to go for me!

Unit testing

We had a discussion that, due to the nature of this code, there is a lot of correctness that would be covered by integration tests (https://github.com/Cambridge-ICCS/FTorch/issues/62), and unit testing would...

Unit testing

fwiw, pfunit was pretty easy to build locally (in non-MPI mode at least).