fourkeys icon indicating copy to clipboard operation
fourkeys copied to clipboard

Set tag usages on images used in 'cloud run'

Open fbtravi opened this issue 2 years ago • 4 comments

Hi, I was looking at the issue, and I realized that it would be easier if the cloud runs point to images by tag. So when new images were implanted it would be enough to change the tag .

If it's valid, I'm willing to implement it.

fbtravi avatar Nov 30 '22 19:11 fbtravi

Heya! Sounds promising. Before you start implementing, can you briefly describe where the changes will need to be made?

davidstanke avatar Dec 08 '22 19:12 davidstanke

Hi,

Taking into account the docs, I believe that in two places or just one depending on the path we follow.

Using the latest tag, we only need to change it when creating the cloud run, and no longer point to image_path@sha256:...., but image_path:latest. My opinion is the best way out.

If we want to use a custom tag, we have to inform the tag when uploading the docker image, and do the same operations as setting the tag on the image pointed to by the cloud run.

The latest tag is a default tag for the last image in the repository.

fbtravi avatar Dec 09 '22 14:12 fbtravi

Ohhhhh. I think I see what you're saying. As a general rule, I try to avoid using latest since it's unspecific. I find that it's error-prone because it's too easy for deployments to get mixed up (e.g. if you need to roll back, you can roll back to a config with a specific hash). (here's an article about this topic)

What do you think?

davidstanke avatar Dec 09 '22 15:12 davidstanke

I had only thought about the ease of use, but I understand and agree with the weak points of latest, so a good way out would be a different tag?

If so, would you have a tag suggestion?

fbtravi avatar Dec 09 '22 18:12 fbtravi