dora icon indicating copy to clipboard operation
dora copied to clipboard

Format and lint all node-hub components with ruff

Open NellyWhads opened this issue 9 months ago • 4 comments

  • Add ruff's E rule to all components
  • Use ruff format on all components
  • Manually resolve the rest of the E group of linting violations adhering to file-local coding paradigms as closely as possible

Haven't assigned myself to be working on https://github.com/dora-rs/dora/issues/878 since I'm a little unsure if the maintainers will be comfortable with the ruff format on the Pythonic components.

NellyWhads avatar May 01 '25 04:05 NellyWhads

I can also add in a CI stage for ruff format and ruff check if that would be favorable.

NellyWhads avatar May 01 '25 04:05 NellyWhads

I think it would be great indeed to check it in the CI/CD

haixuanTao avatar May 09 '25 15:05 haixuanTao

@haixuanTao - rebased and applied - GHA go brr.

NellyWhads avatar May 10 '25 04:05 NellyWhads

Triage: What's the status of this PR? Is this still needed?

phil-opp avatar Aug 19 '25 09:08 phil-opp