pelorus icon indicating copy to clipboard operation
pelorus copied to clipboard

(WIP for after MVR) Add ratelimiting and caching to the GitHub release collector

Open KevinMGranger opened this issue 2 years ago • 5 comments

This is still a WIP, and master has drifted from it. Still, I think it's important, and want it here as a reminder and for visibility once we can resume work on it.

It can serve as a model for how we'd introduce similar things to other collectors.

KevinMGranger avatar Sep 14 '22 20:09 KevinMGranger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from kevinmgranger by writing /assign @kevinmgranger in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 14 '22 20:09 openshift-ci[bot]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Sep 14 '22 20:09 openshift-ci[bot]

@KevinMGranger: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Nov 09 '22 16:11 openshift-merge-robot

/hold Let's revisit this after #720 is merged.

KevinMGranger avatar Jan 23 '23 19:01 KevinMGranger

@KevinMGranger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-e2e-openshift 2eec54ddeff5197844e56e1381cd5c8db82777c7 link true /test 4.12-e2e-openshift
ci/prow/4.13-e2e-openshift 2eec54ddeff5197844e56e1381cd5c8db82777c7 link true /test 4.13-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 09 '24 19:09 openshift-ci[bot]