pelorus icon indicating copy to clipboard operation
pelorus copied to clipboard

Introduce datastructures from committime cleanup

Open KevinMGranger opened this issue 1 year ago • 4 comments

I'm splitting up #720 into pieces so it's easier to review. This is an unobtrusive change, just copying over datastructures from that PR. (And unit tests for one of them).

Side note: make unit-tests gives me a bunch of ModuleNotFoundError: No module named 'exporters' errors. What gives?

KevinMGranger avatar Aug 05 '23 00:08 KevinMGranger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from kevinmgranger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 05 '23 00:08 openshift-ci[bot]

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1043-f4e8487 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

github-actions[bot] avatar Aug 05 '23 00:08 github-actions[bot]

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr1043-b5a41bc \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

github-actions[bot] avatar Aug 23 '23 20:08 github-actions[bot]

@KevinMGranger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-e2e-openshift 52c35faa0551e7ab9e740b793844bdf061d11f94 link true /test 4.10-e2e-openshift
ci/prow/4.12-e2e-openshift 52c35faa0551e7ab9e740b793844bdf061d11f94 link true /test 4.12-e2e-openshift
ci/prow/4.13-e2e-openshift 52c35faa0551e7ab9e740b793844bdf061d11f94 link true /test 4.13-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 09 '24 20:09 openshift-ci[bot]