Darrel O'Pry

Results 377 comments of Darrel O'Pry

@zerolab how do you want to proceed on this PR? @paul-apacio doesn't seem to be responding, do you feel it is important enough that one of us should wrap it...

It seems trivials and also looks like @engAmireng is also working on something similar. I'm going to close this in favor of active ongoing work and issues else where.

While it probably isn't ideal, I think having the weird config helps surface to developers we need to address url handling in grapple.

I feel like the wagtail documentation should maybe clarify that core no longer depends on BASE_URL and that contributed and 3rd Party modules may need it. Has there been any...

@kbayliss the URL generation issues in wagtail are more generalize than just redirects so bears some thought. see #274 and #306

This is fixed. I created #328 to add test coverage for this issue.

I did a test today and confirmed that RichTextBlocks are still creating relative urls `/media/images/wagtail-grapple.width-800.png` to images while ImageFields and ImageChooserBlocks are generating fully qualified URLS `http://localhost:8000/media/original_images/wagtail-grapple.png`

@jffr do you still have any inclination to work on this PR?

@flyte @zerolab I think the underlying issue here may be that query_params isn't documented... looking at the code in register_singular_query_field it looks like the query params are passed to the...

dug a little more and... - [register_query_field.inner.Mixin.resolve_singular](https://github.com/torchbox/wagtail-grapple/blob/4e0a5120d3956876220a2d39872f1470c48f3080/grapple/helpers.py#L115) passes kwargs to get... (kwargs should be constrained to the arguments from the field definition) - [register_query_field.inner.Mixin.resolve_plural](https://github.com/torchbox/wagtail-grapple/blob/4e0a5120d3956876220a2d39872f1470c48f3080/grapple/helpers.py#L121) passes kwargs to [resolve_queryset](https://github.com/torchbox/wagtail-grapple/blob/4e0a5120d3956876220a2d39872f1470c48f3080/grapple/utils.py#L56) where they...