Darrel O'Pry

Results 377 comments of Darrel O'Pry

@oliamb do you have time to address the lint issues, that might help get this on a maintainers radar for review.

I would treat upstream lint issues as out of scope, if I did want to fix them I would submit it as a separate PR.

@auvipy do you have any thoughts on clearing the lint issues?

@Kraust I think in theory your proposal makes sense. Can you open a PR for a more in depth discussion of the implementation?

This looks like a reasonable bug. We may in fact want to fully support access token JWTs in the future. We currently only do JWTs for identity tokens and we...

@n2ygk a separate text field for the full access token?

I'd like to be certain about spec compliance before we make any decision about whether we shouldn't. But I am inclined to agree with @n2ygk and to not make this...

@davideke1 and what are you sending in the request? what client_id are you using? is the client_secret correct? What is the client id and secret for your app?

@davideke1 What google client_id? the client_id should be set on your application. Are you send the client_id from the application or a client_id you got from google? DOT is an...

It looks like you want people to login to your website using their google credentials. Is that what you're trying to acheive?