Ryan May

Results 784 comments of Ryan May

No worries. I do feel like this is still a problem overall, I'm just not satisfied with any of the solutions so far.

There's a bunch of linting failures still here.

Ping @kgoebber don't know if you missed me reviewing this.

@jthielen So we just need some help validating that what we're doing is actually correct. A *scholarly* source to cite for the method plus some good values to double check...

Thanks for kicking the tires on this calculation. Given that unit error, the implementation of the calculation is definitely not correct. Whether that's causing the difference in values, though, is...

Well, this exists: https://github.com/scls19fr/windrose

@akrherz have you tried submitting your improvements to: https://github.com/python-windrose/windrose ?

I'm not against including the functionality in MetPy, just wondering if the better thing is to play ball with the other project (which has taken the old code and moved...

@ocefpaf I'd say we'd be happy to incorporate it if there's interest on the windrose end.

@ocefpaf Are there any tests? 😉