doorstop icon indicating copy to clipboard operation
doorstop copied to clipboard

Why does find_root need to find the root of the repo

Open michaelnt opened this issue 7 years ago • 4 comments

It can be useful to use the -j option to point to some folder within a (large) repo to speed up doorstop, but vcs operations fail in this case as find_root doesn't find a .svn/.git folder.

Can we only use find_root when a root isn't specified and no longer require that the root of a project is the same as the root of the checkout\working copy?

michaelnt avatar May 16 '17 15:05 michaelnt

I think that was an oversight. Unless I'm missing something, it seems like we could let the --project option completely override root detection.

jacebrowning avatar May 16 '17 16:05 jacebrowning

I think that is happening in some places, so perhaps this is just a bug in the server. I'll look at it some more

On Tue, 16 May 2017, 5:20 pm Jace Browning, [email protected] wrote:

I think that was an oversight. Unless I'm missing something, it seems like we could let the --project option completely override root detection.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jacebrowning/doorstop/issues/276#issuecomment-301835533, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQLw3nv0CNrdv98e6Cc7RoVgqELe7AOks5r6czPgaJpZM4Ncq0N .

michaelnt avatar May 16 '17 19:05 michaelnt

Any news on this issue? I'm trying to use the -j (--project) argument to Doorstop and I assumed that it would override the root detection. But as you have discussed above, it doesn't seem to work in that way. I found a work-around by creating a directory named ".git" in a subdirectory where I wanted to run doorstop, but I'm not sure what git thinks about this. It would be nice if the -j argument would override the root-finding mechanism.

henrik-garbergs avatar Jan 31 '20 13:01 henrik-garbergs

I'd gladly accept a pull request that allows --project specification to completely override root detection.

jacebrowning avatar Jan 31 '20 15:01 jacebrowning