Sean Callan

Results 196 comments of Sean Callan

Awesome feedback! I don't personally use the generators and have found maintaining them to be a _tad_ bit a pain over time (we've got generators here: https://github.com/slime-lang/phoenix_slime). That said if...

> Either add me to the org, or get ready for an MR, let share some directions on it. I invited you moments after adding this issue 😁

Thanks for the PR @mattpolzin! I'll spend some time today reviewing this but at a quick glance this looks good and has test coverage 🎉

I found potentially 2 other issues with our parsing: 1. Parsing relationships also requires `"data"` but per the spec it is **not** required: https://jsonapi.org/format/#document-resource-object-relationships. In our case some of our...

@jherdman I'm available to help if you'd like a hand. Having some idea of what folks like @zacksiri would find useful would be helpful; I built an example app for...

Hello hello @lasseebert! Happy to lend a hand if you need it. Feel free to ping me here, Twitter, or Slack 😁

I'm leery of suggesting it but do we want to consider `jsonapi_plug` and `jsonapi_raxx` packages, with the former being included by default maybe? When we looked to remove our dependency...

@CrowdHailer I don't have a PR but that's how we do it: https://github.com/ueberauth/guardian/blob/master/lib/guardian/plug/ensure_authenticated.ex#L1 ```elixir if Code.ensure_loaded?(Plug) do defmodule Guardian.Plug.EnsureAuthenticated do end end ``` It works. It's not pretty. Especially when...

@europ sorry it's taken someone so long to get back to you. I'm open to accepting this change if you'd be willing to rebase and resolve conflicts 👌 @prontolabs/core any...

@naps62 is your code somewhere we could take a peek at?