Evaluate `base5` in `cider-result-overlay-face`'s `:box`

[dalugm]

• [X] I searched the issue tracker and this hasn't been PRed before.
• [X] My changes are not on the do-not-PR list for this project.
• [X] My commits conform to the git conventions.
• [ ] My changes are visual; I've included before and after screenshots.
• [ ] I am blindly checking these off.
• [X] Any relevant issues or PRs have been linked to.

[loganlinn]

Want to second this patch -- I made the same changes to fix error (below) I was encountering during startup. The base5 needs to be backquoted for valid :box face attribute.

Debugger entered--Lisp error: (error "Invalid face box" :line-width -1 :color base5)
  set-face-attribute(cider-result-overlay-face #<frame *scratch* – Doom Emacs 0x3011df0> :background "#23272e" :box (:line-width -1 :color base5))
  face-spec-set-2(cider-result-overlay-face #<frame *scratch* – Doom Emacs 0x3011df0> (:background "#23272e" :box (:line-width -1 :color base5)))
  face-spec-recalc(cider-result-overlay-face #<frame *scratch* – Doom Emacs 0x3011df0>)
  custom-theme-recalc-face(cider-result-overlay-face)
  #<subr enable-theme>(doom-one)
  apply(#<subr enable-theme> doom-one)
  #f(advice cider--docview-adapt-to-theme :after #<subr enable-theme>)(doom-one)
  apply(#f(advice cider--docview-adapt-to-theme :after #<subr enable-theme>) doom-one)
  #f(advice cider--stacktrace-adapt-to-theme :after #f(advice cider--docview-adapt-to-theme :after #<subr enable-theme>))(doom-one)
  apply(#f(advice cider--stacktrace-adapt-to-theme :after #f(advice cider--docview-adapt-to-theme :after #<subr enable-theme>)) doom-one)
  enable-theme(doom-one)
  #<subr load-theme>(doom-one t nil)
  apply(#<subr load-theme> (doom-one t nil))
  #f(advice solaire-mode--prepare-for-theme-a :after #<subr load-theme>)(doom-one t nil)
  funcall(#f(advice solaire-mode--prepare-for-theme-a :after #<subr load-theme>) doom-one t nil)
  (prog1 (funcall fn theme no-confirm no-enable) (if (and (not no-enable) (custom-theme-enabled-p theme)) (progn (setq doom-theme theme) (put 'doom-theme 'previous-themes (or last-themes 'none)) (doom-run-hooks 'doom-load-theme-hook))))
  (let ((last-themes (copy-sequence custom-enabled-themes))) (mapc #'disable-theme custom-enabled-themes) (prog1 (funcall fn theme no-confirm no-enable) (if (and (not no-enable) (custom-theme-enabled-p theme)) (progn (setq doom-theme theme) (put 'doom-theme 'previous-themes (or last-themes 'none)) (doom-run-hooks 'doom-load-theme-hook)))))
  (progn (let ((last-themes (copy-sequence custom-enabled-themes))) (mapc #'disable-theme custom-enabled-themes) (prog1 (funcall fn theme no-confirm no-enable) (if (and (not no-enable) (custom-theme-enabled-p theme)) (progn (setq doom-theme theme) (put 'doom-theme 'previous-themes (or last-themes 'none)) (doom-run-hooks 'doom-load-theme-hook))))))
  (unwind-protect (progn (let ((last-themes (copy-sequence custom-enabled-themes))) (mapc #'disable-theme custom-enabled-themes) (prog1 (funcall fn theme no-confirm no-enable) (if (and (not no-enable) (custom-theme-enabled-p theme)) (progn (setq doom-theme theme) (put 'doom-theme 'previous-themes (or last-themes ...)) (doom-run-hooks 'doom-load-theme-hook)))))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((last-themes (copy-sequence custom-enabled-themes))) (mapc #'disable-theme custom-enabled-themes) (prog1 (funcall fn theme no-confirm no-enable) (if (and (not no-enable) (custom-theme-enabled-p theme)) (progn (setq doom-theme theme) (put ... ... ...) (doom-run-hooks ...)))))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((last-themes (copy-sequence custom-enabled-themes))) (mapc #'disable-theme custom-enabled-themes) (prog1 (funcall fn theme no-confirm no-enable) (if (and ... ...) (progn ... ... ...))))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
  doom--load-theme-a(#f(advice solaire-mode--prepare-for-theme-a :after #<subr load-theme>) doom-one t)
  apply(doom--load-theme-a #f(advice solaire-mode--prepare-for-theme-a :after #<subr load-theme>) (doom-one t))
  load-theme(doom-one t)
  (progn (load-theme doom-theme t))
  (if (and doom-theme (not (custom-theme-enabled-p doom-theme))) (progn (load-theme doom-theme t)))
  doom-init-theme-h()
  run-hooks(after-init-hook delayed-warnings-hook)
  command-line()

---

doom info

generated  Jun 15, 2024 19:23:46
system     Ubuntu 22.04.3 LTS Linux 5.15.133.1-microsoft-standard-WSL2 x86_64
emacs      30.0.50 master 9e8c0ec99 EMACSDIR=~/.config/emacs/
           EMACS=/nix/store/yg7r1b5rnaiz49jxky06fl0dwzvzvvgm-emacs-pgtk-20240615.0/bin/emacs
doom       3.0.0-pre PROFILE=_@0 HEAD -> master, origin/master, origin/HEAD 517daa4ed 2024-06-03
           16:22:10 -0400 ~/.config/doom/
shell      ~/.nix-profile/bin/zsh
features   CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBSYSTEMD
           LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3
           THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS GTK3 ZLIB
traits     batch server-running envvar-file custom-file
modules    :config use-package :completion (company +childframe) (vertico +icons) :ui doom
           doom-dashboard doom-quit (emoji +unicode +github) hl-todo indent-guides minimap modeline
           nav-flash ophints (popup +defaults) tabs (treemacs +lsp) unicode (vc-gutter +pretty)
           vi-tilde-fringe window-select workspaces zen :editor evil file-templates format snippets
           word-wrap :emacs (dired +ranger +icons) electric (ibuffer +icons) undo vc :term eshell vterm
           :checkers syntax (spell +flyspell +hunspell) :tools direnv docker editorconfig (eval
           +overlay) (lookup +dictionary +offline) lsp (magit +forge) make (pass +auth) pdf prodigy rgb
           tree-sitter terraform upload :os (tty +osc) :lang (cc +lsp) (clojure +lsp +tree-sitter) data
           (elm +lsp +tree-sitter) emacs-lisp (go +lsp) (graphql +lsp) json (java +lsp +tree-sitter)
           (javascript +lsp +tree-sitter) (kotlin +lsp) (lua +lsp +fennel) (markdown +grip) (nix +lsp
           +tree-sitter) (org +contracts +hugo +dragndrop +gnuplot +journal +jupyter +passwords +pandoc
           +pomodoro +present +pretty +roam2) plantuml (python +cython +lsp +poetry +pyright
           +tree-sitter) (rust +lsp +tree-sitter) (sh +lsp +tree-sitter) (web +lsp +tree-sitter) (yaml
           +lsp +tree-sitter) :app everywhere (&user openai) :config (default +bindings +smartparens)
packages   (aggressive-indent) (button-lock) (crux :recipe (:host github :repo bbatsov/crux) :pin
           f8789f67a9d2e1eb31a0e4531aec9bb6d6ec1282) (evil-cleverparens :recipe (:host github :repo
           emacs-evil/evil-cleverparens) :pin 134fe3396f975fb1ad261f52cd113f42ac1da4fc) (fence-edit
           :recipe (:host github :repo aaronbieber/fence-edit.el) :pin
           fab7cee16e91c2d8f9c24e2b08e934fa0813a774) (gh-notify) (graphviz-dot-mode :disable t)
           (highlight-parentheses) (just-mode) (justl) (keycast) (kubel) (kubel-evil) (mermaid-mode)
           (minions) (ob-mermaid :disable t) (obsidian) (ox-gist :recipe (:host github :repo
           punchagan/ox-gist) :pin e9f1f11af0e97fee30c2b15b56c236b1f4e1f400) (outshine) (parseclj)
           (parseedn) (protobuf-mode :recipe (:host github :repo protocolbuffers/protobuf :files
           (editors/protobuf-mode.el)) :pin 28e573e77fc3b453dd242e3848b19e7adbf04984) (v-mode :disable
           t) (vala-mode :disable t) (vertico-posframe :recipe (:host github :repo
           tumashu/vertico-posframe) :pin db9fbc95bb8316165ec74e500a76d6857e6ced1a) (yuck-mode)
           (zprint-mode)
elpa       vterm scrollable-quick-peek quick-peek monkeytype

[hlissner]

Good catch! Thanks for your help.