themes icon indicating copy to clipboard operation
themes copied to clipboard
verified publisher icon doomemacs

meltbus: Fix upper eight colours of vterm

Open spacefrogg opened this issue 3 years ago • 4 comments

vterm produces the colours 8–15 from the face-background of the colours 0–7. Adapt the colours to make, e.g., brightblack visible again

Fixes #765

  • [x] I searched the issue tracker and this hasn't been PRed before.
  • [x] My changes are not on the do-not-PR list for this project.
  • [x] My commits conform to the git conventions.
  • [x] My changes are visual; ~I've included before and after screenshots.~
  • [x] Any relevant issues or PRs have been linked to.

spacefrogg avatar Dec 15 '22 21:12 spacefrogg

Did you check that it works in TUI? doom-lighten and doom-darken don't do anything to their argument when it's not in GUI

gagbo avatar Aug 31 '23 21:08 gagbo

This is, how it looks like in vterm running inside a graphical emacs: image

The next, when running vterm inside emacs -nw which runs inside another vterm.

image

So, you're right. It is only partially working. Suggestions?

spacefrogg avatar Sep 07 '23 19:09 spacefrogg

I guess you can compute the colors that you like from GUI, and then hardcode the value in the theme, so you dodge the doom-darken/doom-lighten call.

You can evaluate (doom-lighten (doom-color 'red) 0.3) in a scratch buffer with the theme loaded to see the value (or use SPC h F to look at the faces and have the value directly there)

gagbo avatar Sep 08 '23 06:09 gagbo

I fixed it (and some other things). First image shows vterm in GUI emacs: image

Second image shows vterm in emacs -nw inside vterm: image

spacefrogg avatar Sep 10 '23 13:09 spacefrogg