[Theme-request] winter is coming

[tx46]

Describe your request

Hey guys, I really like the Winter is Coming themes, both the dark and the light variant. I would like to port these to Doom Emacs but I have no idea how to get started.

If I get a few pointers I might be able to create the PR myself. Otherwise - would anyone else care to do it?

Briefly explain its use-case

n/a

[hlissner]

(I moved this to doomemacs/themes, since that is our themes repo.)

I'm assuming you're referring to this Winter is Coming theme? I'll welcome a PR for it.

a few pointers

1. Copy themes/doom-one-theme.el to themes/doom-winter-is-coming-theme.el,
2. Edit the metadata in the header comment,
3. Rename all references to doom-one to doom-winter-is-coming,
4. Adjust the faces accordingly.

By convention, our themes avoid the following:

• Setting :fonts or :inheriting from variable-pitch, fixed-pitch, or derivative font faces.
• Setting :heights for faces. E.g. org-level-N faces.

Hope that helps!

[tx46]

I put it under ~/.doom.d/themes but I honestly can't even figure out how to load it. How can I load the theme after I created the file so I can test the colors?

EDIT: Ignore this, I am a fool and the filename needs to end with -theme

[tx46]

Just as a follow-up, I can't really get it to look good. I'm attaching the theme as it is if someone wants to work on it. I don't have the competence for this.

https://pastebin.com/uKewkm5Z

Colors can be found here: https://github.com/johnpapa/vscode-winteriscoming/blob/master/themes/WinterIsComing-dark-blue-color-theme.json

[tx46]

@hlissner how can I assign styles to certain parts of the theme, e.g.,

             (keywords       (cyan :weight "bold"))

[tx46]