themes icon indicating copy to clipboard operation
themes copied to clipboard

`markdown-mode`: header-face size & color

Open stradicat opened this issue 3 years ago • 3 comments

Hierarchical size & color modifications, so that larger, structured markdown files become a bit easier to read, keeping the palette simple.


  • [x] I searched the issue tracker and this hasn't been PRed before.
  • [x] My changes are not on the do-not-PR list for this project.
  • [x] My changes are visual; I've included before and after screenshots.
  • Gruvbox

    • Before: Captura de Pantalla 2022-08-02 a la(s) 12 47 59

    • After: Captura de Pantalla 2022-08-02 a la(s) 12 48 23

  • Gruvbox Light

    • Before: Captura de Pantalla 2022-08-02 a la(s) 12 46 33

    • After: Captura de Pantalla 2022-08-02 a la(s) 12 47 04

  • Doom-One

    • Before: Captura de Pantalla 2022-08-02 a la(s) 12 49 24

    • After: Captura de Pantalla 2022-08-02 a la(s) 12 49 48

  • Doom-One Light

    • Before: Captura de Pantalla 2022-08-02 a la(s) 12 50 33

    • After: Captura de Pantalla 2022-08-02 a la(s) 12 50 51

stradicat avatar Aug 02 '22 16:08 stradicat

I've temporarily converted this to a draft because this PR needs some work. Specifically, I have intentionally avoided adjusting :height's on org and markdown headings. If we're going to add it, I want it standardized behind a variable that's disabled by default, and have it available to all themes.

That said, this is not a request for you to change the PR. The decision rests on some other work that I have brewing for this project. I will get back to this soon.

hlissner avatar Aug 02 '22 23:08 hlissner

Hi @hlissner!

Thanks for considering my PR; no worries, standardization is something I'd do myself for a project like this, with the least amount of friction possible.

Cheers!

stradicat avatar Aug 02 '22 23:08 stradicat

For completeness, the meltbus theme has such a variable, doom-meltbus-uniform-font-size, but it is disabled by default (because I like having larger headers, and there was no such discussion when I created it). This being said, I completely support this (also that font heights are uniform by default). So, also take this as a naming suggestion.

spacefrogg avatar Dec 16 '22 14:12 spacefrogg