themes icon indicating copy to clipboard operation
themes copied to clipboard

theme: add doom-feather-{dark,light}

Open Plunne opened this issue 2 years ago • 3 comments

Hi!

This is my theme in both colors : Feather Dark and Light.

Feather means plume in french which my nickname is derivated from.

Dashboard + Minibuffer 2022-07-29_02-29 2022-07-29_02-35_1

Org Mode + Treemacs 2022-07-29_02-05_1 2022-07-29_01-55_1

Prog Mode + Treesitter + Rainbow parentheses + DAP 2022-07-29_02-06_2 2022-07-29_01-57

Thanks!

Plunne avatar Jul 30 '22 18:07 Plunne

Hi!

Do you mind amending your commit to conform to our conventions and do you mind adding your themes to the list in the README

thanks! Great work!

jeetelongname avatar Jul 31 '22 15:07 jeetelongname

Hi!

Do you mind amending your commit to conform to our conventions and do you mind adding your themes to the list in the README

thanks! Great work!

Hi! I've never heard of a convention. I didn't add it in the README. Henrik just said to me putting the themes into the themes directory then PR. :)

Plunne avatar Aug 03 '22 17:08 Plunne

Thanks for the PR! I'll be happy to merge this soon, but I've changed it to a draft for now because it needs a little work. Mainly:

1. To add the theme to the list in [README.md](https://github.com/doomemacs/themes/blob/master/README.md#theme-list).

2. And to correct the git message to conform to [our git conventions](https://discourse.doomemacs.org/t/git-conventions/2407).

3. The issues I've highlighted in my review.

If you're not sure how to these two, don't worry about it; I'll do it myself next week (sorry, a bit swamped atm).

Yes, no problem, i let you do this, then you'll be sure it is right. Thanks! :blush:

Plunne avatar Aug 03 '22 20:08 Plunne