themes icon indicating copy to clipboard operation
themes copied to clipboard

Difficult readability in `helm` using `doom-nord` theme

Open fernandodemorais-jf opened this issue 3 years ago • 2 comments

What happened?

Hello!

First of all, thanks for this great set of themes!

A group of helm faces in doom-themes make readability very difficult, especially in the doom-nord. Added to that, other common faces are not implemented, causing great disparity with the applied color palette. This is the case for:

  1. helm-select image
  2. helm-ff-dotted-directory image
  3. helm-header-line-left-margin image
  4. helm-ff-invalid-symlink image

What did you expect to happen?

I expected a little more contrast, so that the items visualization would not be compromised, and that the other faces mentioned were added to improve support for helm in doom-themes.

So, I expected something like this:

  1. helm-select >> :background region instead of :background selection: image
  2. helm-ff-dotted-directory >> :foreground base6 instead of :foreground grey: image
  3. helm-header-line-left-margin >> :foreground yellow :weight 'bold: image
  4. helm-ff-invalid-symlink >> :foreground red: image

Steps to reproduce

  1. Install doom-themes and helm from MELPA;
  2. Configure to use doom-nord and start helm-mode:
(load-theme 'doom-nord t)
(require 'helm)
(require 'helm-config)
(setq helm-echo-input-in-header-line t)
(helm-mode 1)
  1. Start GNU Emacs and use helm.

System Information

  • Emacs version: 27.2
  • Emacs distro: GNU Emacs (Vanilla)
  • Operating system: Arch Linux
  • Installed commit of doom-themes: ac359fc
  • Which theme are you using: doom-nord

fernandodemorais-jf avatar Jul 08 '21 00:07 fernandodemorais-jf

:warning: This issue has been automatically marked stale because due to 60 days of inactivity. If this issue is still valid, please reply to it or it will be closed in 7 days.

github-actions[bot] avatar Nov 15 '21 12:11 github-actions[bot]

Please add support for Ledger Report

UtaAmb avatar Jan 02 '22 13:01 UtaAmb