[Feature] Ayu themes

[seagle0128]

Ayu color scheme seems very clean and elegant. Can you please integrate it to doom-themes?

Reference: https://github.com/ayu-theme/ayu-colors https://github.com/nonissue/.emacs.d/blob/master/themes/ayu-theme.el

[ianyepan]

Second! Ayu is beautiful.

[LoveSponge]

Hi, I third this - so i'm trying to make it ; I've copy/pasted a file in /themes directory and renamed it, started changing some values etc... how do i test it? i've tried to set the theme in config but the name is not recognised - i think i need to build/compile doom-themes but i've got no idea how (i've tried doom sync but it prints nothing to compile, so i guess this is wrong usage for this command)...

i'm a n00b with emacs and lisp in general but i'd really like to get this implemented, any help is appreciated.

Cheers, LS

[edmundmiller]

@LoveSponge You can do like I did here. https://github.com/Emiller88/doom-emacs-private/blob/master/themes/doom-ayu-light-theme.el

The file naming and location is important.

I'm struggling with the colors because they're inconsistant in their colors across different editor themes.

[LoveSponge]

so i've sort of got something, they require some custom stuff though so for different languages it could be kind of ugly... i'll submit a pr anyway to get the code out there.

Edit: Created PR #499 - feel free to try it out and be harsh, i'd quite like to get this right.

[ema2159]

Almost complete! The only one missing would be Ayu-dark. @LoveSponge, given that you're familiar with this set of themes, do you feel like implementing the dark variant?

[LoveSponge]

@ema2159 honestly I barely had the time to get the other two over the line, I have the scaffolding set out, I think there was just an issue where certain org highlights were using ayu white colours (in mirage theme) for some reason... I'll see if I can't fix that one up and then use the template to copy /paste for ayu-dark

[ejez]

Thanks for the work on this theme!

I would like to report this issue in org mode:

Source code blocks have a white background. Also, in third line #+TITLE: is not visible.

[seagle0128]

I tried the themes. One suggestion, the line numbers are too bright (or dark). Thoughts?

[ianyepan]

I tried the themes. One suggestion, the line numbers are too bright (or dark). Thoughts?

I agree. Perhaps using the face of "comment" for "line-number" can work well?

[seagle0128]

FYI

Some screenshots: https://github.com/ayu-theme/vscode-ayu

[LoveSponge]

Thanks for all the feedback, @ejez @seagle0128 @ianpan870102

Unfortunately i've not spent much time since the last commit;

With regards to your actual comments: Line numbers: Agreed, I can modify them. vscode styling: Agreed, i was actually using vscode as much as possible to copy the colours. Org mode code style bug: It's known, but i've got no idea how to fix it, strangely in ayu-light it's not an issue, what is going wrong?

Any help on these would be appreciated, the code itself is really simple, but i know very little about emacs-lisp and moreover only a tip of the iceberg on how emacs themes work. (i used M-x describe-theme ALLOT.)

[mattsawyer77]

Thanks for the work on this nice theme. I noticed that the ayu-mirage theme is already available(?) I can use it -- though each time I open emacs, it asks me whether I trust the theme.

[ianyepan]

though each time I open emacs, it asks me whether I trust the theme.

Did you provide an argument of t? Like so: (load-theme 'doom-ayu-mirage t)

[mattsawyer77]

aha, thank you @ianpan870102, I had indeed forgotten the t.

[gnuyent]

Hi @LoveSponge, thanks for the hard work! I looked at some other themes (specifically Iosvkem) and they use the following for highlighting org-mode code blocks:

;; relevant colors
(common-bg       '("#0a0e14" "black"   "black"  ))
(ui-line               (doom-lighten common-bg 0.07))

;; source/quote block highlighting
((org-block &override) :background COLOR_HERE)            ;; highlight the code block
((org-quote &override) :background COLOR_HERE)            ;; highlight the quote block
((org-block-begin-line &override) :background COLOR_HERE) ;; highlight begin_src and end_src

Other themes seem to have these as the same color.

I've been playing around with some ayu-dark colors with bg-alt for COLOR_HERE and it looks quite nice.

I'm also quite new to Emacs so I'm not sure if this is the best way of changing the colors.

[LoveSponge]

Thank you all for your awesome feedback, and the help with this, I've just made some ammendments, focusing on org-mode specifically... Whatcha think?

Special thanks to @gnuyent for the org-x-syntax names!

Changes:

• Line numbers
• Org mode faces
• Ayu Dark

MIRAGE

LIGHT

[NEW] DARK

[seagle0128]

@LoveSponge The new changes look great! Cannot wait for trying!

[LoveSponge]

@seagle0128 thanks!

I'm actually still making tweaks to a few things, feel free to clone my repository, I don't want to bother the doom devs with a PR until it's actually ready...

Also I came across a bug where some specific magit screen was showing the hunk diff with a white background (similar to how org was doing) but I can't see where... If anyone knows or runs into it please let me know!

Cheers, LS

[gf3]

the lsp highlight colour in ayu light can be hard to read, however i'm pretty new to emacs and i don't know how to fix this:

GIF

[seagle0128]

When the new implementation will be merged?

[JP-Ellis]

@LoveSponge Have you made much more progress on Ayu dark? I am very keen on seeing integrated in Doom :smile:

[ghost]

Hi I am wondering if we can add a contrast mode to the theme? The current theme is a bit hard to distinguish between split panes.

[seagle0128]

@MONO77 You may need window-divider-mode.

[ghost]

Hi @seagle0128 thanks for your tip. However, I don't thinkwindow-driver-mode solves the problem, at least with the ays-light. Here is a screenshot: If you zoom to an extent, there is a really light split that can be barely seen. However, what I was suggesting is making different panes (eg. file explorer and code) having different degree of darkness (like the one in my last post).

Let me use another example to demonstrate:

The two screenshots are using Material Darker theme and Material Darker High Contrast theme respectively in VSCode. As you can see, the second one obviously have more contrast between different panes, which may not be that aesthetically appealing, but is more usable imo.

[seagle0128]

@MONO77 Well, basically I agree with you. window-divider-mode is just a workaround before this is fixed. You can customize window-divider face.