Recent changes in modules/lang/elixir/config.el break "standard" Elixir-LS install

[cdegroot]

I confirm that...

• [x] I searched the issue tracker and found no similar issues.

• [x] I searched the documentation, FAQ, discussion board, and Google for solutions to my issue.

• [x] I read the debugging guide and researched the issue to the best of my ability.

• [x] My issue can be observed on the latest available commit of Doom.

• [x] My issue can be observed on a stable release of Emacs (i.e. doesn't end in .50, .60, or .90–.99)

Describe your issue

I've tried debugging this, but the lsp.el refused to play ball. I know that Elixir language servers are a thing in motion, and probably it's about time to just hardcode the new one (which promises to be The True And Only One for the foreseeable future), expert.

However, in the meantime, it looks like the recent changes to the Elxiir language module broke at least my setup. I have nothing around Elixir in my ~/.doom.d/ except for (elixir +lsp), but when I try opening an Elixir file and starting the language server (M-x lsp), I just get a repeat loop of "language server not found", the option to choose between elixir-ls and credo, I select elixir-ls, and I'm back in the menu.

Reverted the last two relevant changes:

15:12:47 cees@calmwave-arm64-dev:~/.emacs.d.doom/modules/lang/elixir(master)$ git diff
diff --git a/modules/lang/elixir/config.el b/modules/lang/elixir/config.el
index e43980a2c..2161113c1 100644
--- a/modules/lang/elixir/config.el
+++ b/modules/lang/elixir/config.el
@@ -62,17 +62,7 @@
 
   (when (modulep! +lsp)
     (after! lsp-mode
-      (add-to-list 'lsp-file-watch-ignored-directories "[/\\\\]_build\\'"))
-    (after! lsp-elixir
-      ;; HACK: lsp-elixir is hardcoded to use the server `lsp-install-server'
-      ;;   installs, ignoring any system-provided executables. This fixes that,
-      ;;   so long as the user hasn't changed `lsp-elixir-server-command'
-      ;;   themselves,
-      (when (and (member lsp-elixir-server-command
-                         '(("language_server.bat")
-                           ("language_server.sh")))
-                 (executable-find "elixir-ls"))
-        (setq lsp-elixir-server-command "elixir-ls"))))
+      (add-to-list 'lsp-file-watch-ignored-directories "[/\\\\]_build\\'")))
   :config
   (+elixir-common-config 'elixir-mode))

and things worked again.

Steps to reproduce

1. Open Emacs
2. Open an Elixir file
3. M-x lsp

System information

https://pastebin.com/A35BRGqN

[ra-nvk]

I am facing this same issue.

[hlissner]

As of 59e5253 this should be resolved. Let me know if that isn't the case and I'll reopen it. Thanks for bringing it to my attention!

[cdegroot]

Thanks, Henrik. I only use Elixir at work and it's that crazy last-week-before-the-big-holiday-break, but I'll try and schedule some time for a test this week.