doomemacs icon indicating copy to clipboard operation
doomemacs copied to clipboard

module: add :os exwm

Open LemonBreezes opened this issue 3 years ago • 8 comments

Hello everyone, I have written an EXWM module for Doom Emacs, which I hope you will all enjoy.

Some features of note from this module are:

  • Evil support for all EXWM buffers, with the entire suite of commands supported on Firefox-based and Chrome-based web browsers.
  • The ability to edit any input field using Emacs with language detection for selecting the appropriate major mode.

I was going to include a feature for automatically creating/destroying workspaces for EXWM applications but decided not to include it in the initial pull request. I would love to include it in a module flag.

LemonBreezes avatar Jan 07 '22 03:01 LemonBreezes

also can you please rebase your branch to conform to our git conventions I would also split this out into many commits detailing individual changes

jeetelongname avatar Jan 07 '22 03:01 jeetelongname

Thank you. I have just implemented the fixes you stated. I will work on splitting this into several commits following the Git conventions.

LemonBreezes avatar Jan 07 '22 03:01 LemonBreezes

You don't need to close the PR you should be able to turn it into a draft which keeps it open but makes it clear its incomplete (it can't be merged until you put it up for review)

jeetelongname avatar Jan 07 '22 03:01 jeetelongname

You don't need to close the PR you should be able to turn it into a draft which keeps it open but makes it clear its incomplete (it can't be merged until you put it up for review)

Ahh, thank you. I finally found that button.

LemonBreezes avatar Jan 07 '22 03:01 LemonBreezes

Hi @LemonBreezes

I work mostly with R projects, and I'm starting using ESS.

I would be super nice to have plots embedded inside doom-emacs using exwm. I just stumble upon with this post and I'm wondering if this fits in your module. WDYT?

Thanks.

maikol-solis avatar Apr 19 '22 15:04 maikol-solis

Hi @LemonBreezes

I work mostly with R projects, and I'm starting using ESS.

I would be super nice to have plots embedded inside doom-emacs using exwm. I just stumble upon with this post and I'm wondering if this fits in your module. WDYT?

Thanks.

Sure. That seems like an interesting alternative to using temporary files with auto-revert-mode. I am definitely interested in having interesting uses of EXWM added to this module. The module is currently living in exwm-module-for-doom-emacs. Soon I will close this pull request and redo this module for the master branch.

EDIT: I recently also added a commands for editing files in nested Emacs sessions and it has made testing easier for me. But I still need to test that with Evil and add fix whatever keybinding issues arise.

LemonBreezes avatar Apr 20 '22 15:04 LemonBreezes

Sure. That seems like an interesting alternative to using temporary files with auto-revert-mode. I am definitely interested in having interesting uses of EXWM added to this module. The module is currently living in exwm-module-for-doom-emacs. Soon I will close this pull request and redo this module for the master branch.

EDIT: I recently also added a commands for editing files in nested Emacs sessions and it has made testing easier for me. But I still need to test that with Evil and add fix whatever keybinding issues arise.

Excellent! Thanks for this great idea. Even if I've never used EXWM before, it looks very promising.

I'll try your module and see what I can learn and report any issue.

maikol-solis avatar Apr 20 '22 16:04 maikol-solis

Looking forward to see this feature added. Thanks!

oatmealm avatar Aug 04 '22 14:08 oatmealm

Hey there! I'm preparing to move modules out of Doom's core to doomemacs/modules (official modules) and doomemacs/contrib-modules (community-maintained/contributed modules), and am resolving/transferring related PRs and issues. As this repo will no longer house modules (and Github offers no way to transfer PRs), I am closing it, but I'm still interested in its contents. Would you mind re-PRing it to https://github.com/doomemacs/contrib-modules?

There'll be an announcement on Discourse (under #news) this weekend about why this is happening and the general state and direction of Doom, if you're curious.

The reason I'm directing this to contrib-modules instead of modules is because I'm ignorant of EXWM: I see much variation across EXWM configs (and module submissions sent to or discussed with me here (#4004, #3988) or on Discord over the years), and I have trouble telling if this should be "the one", or how to merge them. This stems from the fact that I haven't had time to try out exwm, and am currently a bit too swamped to do so.

My goal for our official modules is to, personally, have a solid grasp (and awareness going forward) of them all, their installed packages, and (at minimum) a working understanding of whatever tools/OSes/languages they're adding support for. This way I can assure a reasonable level of quality control. EXWM is a blind spot for me, so until I grok it and am able to more informed decisions, I'd rather it live in contrib-modules. It also offers the community an opportunity to further improve until I can get around to it.

In any case, sorry for the trouble and thank you for the PR and help!

hlissner avatar Nov 01 '22 16:11 hlissner

when run M-x or recenterf file

Error in post-command-hook (ivy--queue-exhibit): (wrong-type-argument numberp t) 

iT-Boyer avatar Mar 14 '23 22:03 iT-Boyer

This module is outdated and needs to be rewritten.

LemonBreezes avatar Mar 17 '23 16:03 LemonBreezes