react-native-iap icon indicating copy to clipboard operation
react-native-iap copied to clipboard

Published 20 hours ago • verified publisher icon dooboolab-community

feat: add visionOS support

Open okwasniewski opened this issue 1 year ago • 5 comments

This PR adds visionOS support.

I've refactored some parts of the code to take the currently presented scene by wrapping built-in utility RCTKeyWindow() to work in async scenarios.

Testing

  1. npx @callstack/react-native-visionos init App
  2. Add react-native-iap
  3. Check out if it works

Demo

https://github.com/dooboolab-community/react-native-iap/assets/52801365/c2391f3a-c8b9-4fd8-acba-e2871c7aaae7

okwasniewski avatar Dec 19 '23 15:12 okwasniewski

Build is failing because CI needs a newer Xcode version

okwasniewski avatar Dec 20 '23 14:12 okwasniewski

@hyochan can @okwasniewski get some permissions to help work out the CI issue, so this PR can be made to pass CI? His similar visionOS work has been merged in gesture-handler, reanimated, screens, and numerous other projects. It would be great to get IAP support into a release of our react-native-visionos apps soon without the need for local patches :D

matthargett avatar Mar 01 '24 23:03 matthargett

Hey @hyochan, I've fixed the CI and the PR is now ready for review. Let me know if I can help you in any way to get this merged

okwasniewski avatar Mar 05 '24 08:03 okwasniewski

@TheRogue76 was there anything else needed for this to be merged? I'm excited to remove our local patch-package and let other RNV apps start to monetize :)

matthargett avatar Mar 22 '24 19:03 matthargett

@TheRogue76 was there anything else needed for this to be merged? I'm excited to remove our local patch-package and let other RNV apps start to monetize :)

I am not a maintainer of RN IAP, simply an open-source contributor who used this repo at one point and had it marked as watched. I just double-checked the PR. I do not have access to the repo to merge or block the PRs. As far as I see, the PR is perfectly fine.

TheRogue76 avatar Mar 23 '24 09:03 TheRogue76

@TheRogue76 was there anything else needed for this to be merged? I'm excited to remove our local patch-package and let other RNV apps start to monetize :)

I am not a maintainer of RN IAP, simply an open-source contributor who used this repo at one point and had it marked as watched. I just double-checked the PR. I do not have access to the repo to merge or block the PRs. As far as I see, the PR is perfectly fine.

Could you kindly accept this review when you think this PR is good?

hyochan avatar Jun 11 '24 16:06 hyochan

@TheRogue76 was there anything else needed for this to be merged? I'm excited to remove our local patch-package and let other RNV apps start to monetize :)

I am not a maintainer of RN IAP, simply an open-source contributor who used this repo at one point and had it marked as watched. I just double-checked the PR. I do not have access to the repo to merge or block the PRs. As far as I see, the PR is perfectly fine.

Could you kindly accept this review when you think this PR is good?

Approved on my side. As far as i can see, it looks good to me. Not sure if the comment was towards me or not but i figured a double check would not hurt.🙏

TheRogue76 avatar Jun 11 '24 16:06 TheRogue76

Approved on my side. As far as i can see, it looks good to me. Not sure if the comment was towards me or not but i figured a double check would not hurt.🙏

Thank you for taking an interest and reviewing this PR. Based on your involvement, I kindly request that you complete the review for this PR!

hyochan avatar Jun 12 '24 04:06 hyochan