iOS: Many crashes due to lack of thread-safety

[mars-lan]

Please use Discussion board if you want get some help out of it. Please report issue if there is a bug.

Version of react-native-iap

8.0.8

Version of react-native

0.67.4

Platforms you faced the error (IOS or Android or both?)

iOS

Expected behavior

No crashing

Actual behavior

Random crashes with stack trace like this:

Crashed: com.facebook.react.RNIapIosQueue
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000

<compiler-generated> - Line 388412 RNIapIos.addPromise(forKey:resolve:reject:) + 388412
RNIapIos.swift - Line 165 RNIapIos.getItems(_:resolve:reject:) + 165
<compiler-generated> - Line 391604 @objc RNIapIos.getItems(_:resolve:reject:) + 391604

Tested environment (Emulator? Real Device?)

Real device

Steps to reproduce the behavior

This is caused by non-thread-safe access to the dictionary promisesByKey. A serial queue was added to protect some of these accesses but not all. IMHO a better way to protect this is by adding dispatch directly inside of addPromise, resolvePromises & rejectPromises.

[edodusi]

I have those crashes too with 8.1.3 and also this error which I think it's related:

EXC_BAD_ACCESS KERN_PROTECTION_FAILURE 0x0000005f774d5340

...
0x5ed518 RNIapIos.resolvePromises(forKey:value:) + 100 (RNIapIos.swift:100)
0x5f59f0 RNIapIos.productsRequest(_:didReceive:) + 446 (RNIapIos.swift:446)
0x5f5bb8 @objc RNIapIos.productsRequest(_:didReceive:) + 68 (<compiler-generated>:68)
0x3a18 __27-[SKProductsRequest _start]_block_invoke_2 + 188
...

[edodusi]

(also this should be labeled as bug I think)

[aadityapaliwal94]

Can anyone look into this issue? Causing crash on production.

[phillip-kic]

I believe we may be having issues related to this as well. We are seeing crashes on release builds which is preventing us from upgrading in production.

This is occurring when fetching subscription products. The Apple Docs warn that the SKProductsRequestDelegate may not return on a specific thread so feels likely that lack of thread-safety is the issue here?

Stack trace

Hardware Model:     iPhone13,4
Role:               Foreground
OS Version:         iOS 15.5
Exception Type:     EXC_BAD_ACCESS 
Exception Subtype:  KERN_INVALID_ADDRESS


EXC_BAD_ACCESS: Attempted to dereference garbage pointer 0x8000000000000028.

0  App Name                specialized __RawDictionaryStorage.find<A>(_:) (<compiler-generated>)
1  App Name                specialized Dictionary._Variant.removeValue(forKey:) (<compiler-generated>)
2  App Name                specialized Dictionary.removeValue(forKey:) (<compiler-generated>)
3  App Name                RNIapIos.productsRequest(_:didReceive:) (RNIapIos.swift:451:5)
4  App Name                @objc RNIapIos.productsRequest(_:didReceive:) (<compiler-generated>)
5  StoreKit                __27-[SKProductsRequest _start]_block_invoke_2
6  libdispatch.dylib       _dispatch_call_block_and_release
7  libdispatch.dylib       _dispatch_client_callout
8  libdispatch.dylib       _dispatch_queue_override_invoke
9  libdispatch.dylib       _dispatch_root_queue_drain
10 libdispatch.dylib       _dispatch_worker_thread2
11 libsystem_pthread.dylib _pthread_wqthread
12 libsystem_pthread.dylib start_wqthread

[andresesfm]

Not sure but I think this: https://github.com/dooboolab/react-native-iap/pull/1910 might have fixed some memory leaks related to this. If not, please reopen

[mars-lan]

I don't think https://github.com/dooboolab/react-native-iap/pull/1910 addressed the issue as this is to do with thread safety, not memory leaks. Keeping this re-opened for now.

[phillip-kic]

Due to the Google Play Billing Client depreciation we have to upgrade our in production use of react native iap (v6), but every attempt we run into serious crashes such as this one now.

Can anyone confirm if upgrading to Version 7 (First version with Billing Client 4) is safe in production, or if there is a specific version that anyone is using successfully and do not see these crashes?

[phillip-kic]

For anyone else in this issue, we upgraded successfully to version 7. So version 7 does not have this issue, it was introduced in version 8 and that version should be avoided

[andresesfm]

Please create a new ticket if this is still happening on 11.x.x. Also please use the new Bug report template. There's simply not enough information here to try to reproduce. I'll be happy to look at it.

[openpathgit]

This issue is causing our company to move off this library, which is a real shame. Please let us know the path moving forward