react-native-iap icon indicating copy to clipboard operation
react-native-iap copied to clipboard

StoreKit 2 migration 🥳

Open hyochan opened this issue 3 years ago • 12 comments

Discussed in https://github.com/dooboolab/react-native-iap/discussions/1370

Originally posted by neilco June 9, 2021 There's lots of interesting changes coming in StoreKit 2. Just throwing my hat in the ring early for helping out with adding StoreKit 2 support.

hyochan avatar Jul 03 '21 11:07 hyochan

I am currently confused about what we can do with this. Looks like we have nothing to do to change the source code?

Hope someone can give any other insights to this thread.

@neilco Any idea?

hyochan avatar Jul 28 '21 16:07 hyochan

@hyochan I would start by comparing the original StoreKit API to the StoreKit 2 API. They are radically different. Also, check out the Meet StoreKit 2 session from this year's WWDC.

neilco avatar Jul 28 '21 16:07 neilco

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

stale[bot] avatar Apr 18 '22 19:04 stale[bot]

Did anything in the 8.0.0 release of react-native-iap move the needle on this issue, or was 8.0.0 just a migration to Swift?

nchase avatar Apr 20 '22 13:04 nchase

Any news about this migration? Do you need any help?

lukebars avatar Jun 01 '22 10:06 lukebars

@lukebars I have not had a chance to look into this closely. If we can find a starting point that gives us direction, I think it will help us not hesitate to proceed. I'm currently not sure where to start without deepening it.

hyochan avatar Jun 01 '22 10:06 hyochan

@hyochan I'm investigating the migration to SK2, got some methods already working. I'll share my findings in a week or so, when whole transition POC will be complete. Seems like we're gonna need to support both, as SK2 supports only iOS 15.0+.

lukebars avatar Jun 24 '22 09:06 lukebars

@lukebars Sounds fabulous. Looking forward to it!

hyochan avatar Jun 26 '22 10:06 hyochan

Any updates on this @lukebars ?

andresesfm avatar Jul 25 '22 22:07 andresesfm

Hey @andresesfm, I've managed to migrate most of the methods to SK2, now need to do the listeners and so on. I'll publish the branch is somebody wants to get their hands on it. We also need to think about some kind of architecture to support both, as SK1 and SK2 are quite different.

lukebars avatar Aug 02 '22 13:08 lukebars

That's great news @lukebars. Yes, please post your branch so we can start looking at it

andresesfm avatar Aug 02 '22 21:08 andresesfm

Please follow updates/ collaborate here: https://github.com/dooboolab/react-native-iap/discussions/1370

andresesfm avatar Aug 12 '22 22:08 andresesfm

I have just published 11.0.0-alpha.1 with the basic implementation of SK2. Please let me know of any issues

andresesfm avatar Aug 31 '22 16:08 andresesfm

Published 11.0.0-alpha.6 with backwards compatiblity. No longer need to target iOS 15 in order to use the library. However, in order to use sk2 you'll need to target ios 15.0

andresesfm avatar Sep 01 '22 22:09 andresesfm

Hello guys, How can I help? is there any guidance I can walk through to contribute with you? I am interested to work with you on the features

basemanabulsi avatar Sep 07 '22 17:09 basemanabulsi

@basemanabulsi take a look at the next branch, that's where I'm merging the Sk2 changes. Help with testing/ documentation would be greatly appreciated. Also need help exposing the new methods to Js. I'm currently working on backward compatibility. Let me know what interests you the most and I can create a ticket with the details

andresesfm avatar Sep 08 '22 21:09 andresesfm

@andresesfm Awesome, thank you for the guidance. Currently I am browsing and understanding the code more so I can dig into it. Also, I am happy to update the documentation

basemanabulsi avatar Sep 13 '22 03:09 basemanabulsi

@basemanabulsi if you are changing the documentation please do it against the next branch as I'm currently getting it ready for release. Thank you and let me know if any questions

andresesfm avatar Sep 13 '22 04:09 andresesfm

Released 11.0.0-rc.1 Including migration guide: https://github.com/dooboolab/react-native-iap/blob/next/docs/docs/migrate_to_11.0.0.md Please let me know if any issues before the actual 11.0.0 release

andresesfm avatar Sep 14 '22 23:09 andresesfm

Released 11.0.0-rc.3 with updated migration instructions

andresesfm avatar Sep 19 '22 23:09 andresesfm

Released 11.0.0-rc.4 with updated migration instructions. This will be the last RC

andresesfm avatar Sep 21 '22 22:09 andresesfm

PR to merge into main: https://github.com/dooboolab/react-native-iap/pull/1985

andresesfm avatar Sep 21 '22 23:09 andresesfm

Hey @andresesfm, when do you think version 11.0.0 will be released?

emberist avatar Sep 22 '22 09:09 emberist

As soon as we get enough eyes that validate it is stable @emberist. Implementation is complete. The code will be exactly what you'll see in 11.0.0-rc.5 if you want to start integrating and give us feedback, it would be of great help

andresesfm avatar Sep 22 '22 20:09 andresesfm

11.0.0 has been released. Thank you everybody for your feedback. Going forward please create new tickets if you run into any issues

andresesfm avatar Sep 26 '22 17:09 andresesfm