capybara-screenshot-diff icon indicating copy to clipboard operation
capybara-screenshot-diff copied to clipboard

Is it possible for capybara-screenshot-diff NOT to try to require minitest?

Open dolzenko opened this issue 2 years ago • 1 comments

My problem is that I'm not using minitest in my Rails project, but it's being pulled in as a dependency by ActiveSupport and so this [1] test returns true and capybara-screenshot-diff thinks its in MiniTest context, which it isn't. I mean isn't it better to just check const_defined?(MiniTest) or something similar here: https://github.com/donv/capybara-screenshot-diff/blob/6a113e26f5e1fb664f0c359511744e00c9e3e89b/lib/capybara/screenshot/diff/drivers/utils.rb#L40C1-L46

[1] https://github.com/donv/capybara-screenshot-diff/blob/master/lib/capybara/screenshot/diff.rb#L104

dolzenko avatar Oct 24 '23 13:10 dolzenko

Yeah we can do like capybara, use different files to require per different test frameworks

pftg avatar Oct 25 '23 17:10 pftg

@dolzenko removed minitest for rspec integration

pftg avatar Jul 18 '24 06:07 pftg