Arun Donti
Arun Donti
I like the intent of this, but I think we would need to work on a better implementation that won't lead developers into just using blanket suppressions. ### Not very...
Fixtures may not be what I'm looking for. I'm expecting a majority of the users to read the example from the repository `README` versus documentation that is generated for the...
> I'm not sure this is something we want to accept. This is essentially asking for also having a method for to set every property. I think this is something...
In addition to that, there are reasons why we can't determine the logging bucket configuration at synth time, and we rely on a custom resource to call an API to...
> > In addition to that, there are reasons why we can't determine the logging bucket configuration at synth time, and we rely on a custom resource to call an...
`this.instance = lambdaFunc;` Are you adding permissions to the lambda function outside of the construct? It doesn't look like you've added any permissions to the Lambda function at the time...
I tried recreating this locally ,but I'm not seeing any `AwsSolutions-IAM5` errors. Do you have a snippet for the stack that is using this construct?
Closing due to inactivity
Thanks for the detailed write up! As you noted these are three separate changes and I think they should be addressed in different PRs. I'll do a more detailed review...
> @dontirun Regarding comment about 3 separate PRs > > > As you noted these are **three** separate changes and I think they should be addressed in different PRs. >...